Open File from Integrated Terminal in Current Instance

[denisrheault]

From the Integrated Terminal, one should be able to open a file from the command line in the current instance (when running multiple instances of vs code).

Currently the --reuse-window opens the file in the last active window but this is not the wanted behavior. The wanted behavior is much like when ctrl-clicking on a file in the integrated terminal; it opens in the current instance of code.

I have multiple instances of VS code running - one for each projects. Using --reuse-window opens the file in an instance of code that is not related to the project.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Some Editor changes should be specific to an Instance (#50892)
• Can't open more than one instance of vscode (#6112)

[denisrheault]

No, not covered in existing issues. Denis

…

On Thu, Mar 11, 2021 at 8:11 AM vscodebot[bot] ***@***.***> wrote: (Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: - Some Editor changes should be specific to an Instance (#50892) <https://www.github.com/microsoft/vscode/issues/50892> - Can't open more than one instance of vscode (#6112) <https://www.github.com/microsoft/vscode/issues/6112> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#118718 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AITL3MS526YLGM36S4XE5E3TDC6QPANCNFSM4ZAICQXQ> .

[yume-chan]

... should be able to open a file from the command line in the current instance
... --reuse-window opens the file in the last active window

How do you open a file from Integrated Terminal of an inactive window?

[denisrheault]

Why open in the last active window? It should open in the current window. For me using the switch --reuse-window or no switch has the same effect. Normal? Say I open a project in instance A and a second project in instance B. In the interminal terminal of instance A I do 'code -r fileA' the file will open in the last active window (project B) even though it is for project A. Doesn't make sense. If I ctrl-click (open selected) of fileA it opens in project A. This is what I want, but there are things I can do from command line but not with ctrl-click. Like a bash function that finds the selected file and opens it once the directory is found.

…

On Thu, Mar 11, 2021 at 10:10 PM Simon Chan ***@***.***> wrote: ... should be able to open a file from the command line in the current instance ... --reuse-window opens the file in the last active window How do you open a file from Integrated Terminal of an inactive window? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#118718 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AITL3MT7VCPM2RDYNRG64CTTDGA2RANCNFSM4ZAICQXQ> .

[denisrheault]

Any progress on this? Is it clear what I am asking for? Thanks in advance.

[Tyriar]

Can you elaborate a little on what you mean here? If you open a file from the CLI, it will open it in the most relevant windows AFAICT. See this gif how I open xterm.js/README.md from the vscode window, but it opens in the correct window:

[denisrheault]

Hi Tyriar,

From the CLI, I want the same behavior as when clicking "Open File in Editor (ctrl + click)"; the file opens in the current window (same as the integrated terminal).

I realized while trying to replicate to make a GIF is that the behavior is as expected as long as I don't SSH into another server.

Without SSH'ing, it actually works as expected, as shown in this GIF. In the GIF I show that in the integrated terminal I can hover a filename (xrun.log) and ctrl-click'ing opens the file in the current window.

I repeated the same thing, first showing that 'code ./xrun.log' still opens the file in the current window, next SSH into another server and opens the same file (it's a shared drive therefore file exists on both servers).
Unexpectedly another Window opens xrun.log. Now let's try hovering on the filename and ctrl-click'ing opens the file in the current window as expected.

Now that I understand that the problem is with SSH and not being able to open a file in a window (process) that is running on a different machine.
I don't think there's anything that could be done in this case. Let me know what you think.
Thanks!

[aeschli]

It's a regression that was caused by moving the terminal process under the main process:
Duplicate of #121926