Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate terminal workspace shell/profiles with trusted workspaces #119344

Closed
Tyriar opened this issue Mar 19, 2021 · 1 comment
Closed

Integrate terminal workspace shell/profiles with trusted workspaces #119344

Tyriar opened this issue Mar 19, 2021 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality on-testplan terminal Integrated terminal issues workspace-trust Trusted workspaces
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 19, 2021

Tentatively setting to April to track.

@sbatten @lszomoru do you think we would be ready to do this in April?

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues workspace-trust Trusted workspaces labels Mar 19, 2021
@Tyriar Tyriar added this to the April 2021 milestone Mar 19, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Apr 21, 2021

@sbatten FYI this is done, though workspace terminal settings will be disabled until workspace trust is enabled by default and I remove application scope in #121470. I ripped out the old workspace shell permissions code while making a large refactor which would have taken a lot more effort to bring it along.

I feel it's a relatively minor feature with workarounds available so it's not the end of the world if it breaks for a month so that we can get more done with tabs and reduce debt at the same time.

@Tyriar Tyriar closed this as completed Apr 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan terminal Integrated terminal issues workspace-trust Trusted workspaces
Projects
None yet
Development

No branches or pull requests

2 participants