Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification usage guidelines #119463

Closed
2 tasks
isidorn opened this issue Mar 22, 2021 · 29 comments
Closed
2 tasks

Notification usage guidelines #119463

isidorn opened this issue Mar 22, 2021 · 29 comments
Assignees
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2021

I think we should:

  • Revisit all internal usages of notifications and consider if they should be converted to modal dialogs if they require immediate user actions
  • Once we figure out the best thing to do in VS Code core we should update our extension guidelines so extension can follow the patterns that we do in core

Ideally this exercise would move "important" to be modal dialogs, and thus we can start exercising a more aggressive hide strategy towards regular notifications.

fyi @devinvalenciano @meganrogge

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 22, 2021
@isidorn isidorn added this to the April 2021 milestone Mar 22, 2021
@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2021

The terminal workspace permissions dialogs should be modals imo, but that might get fixed when we adopt trusted workspaces #119344

@isidorn
Copy link
Contributor Author

isidorn commented Apr 21, 2021

@misolori is working on a nice flow chart to make it easy to distinguish if a usage should use a modal dialog or a notification.
Until he has that, here are some rules of thumb which I think can be helpful:

  • User interaction immediately needed -> modal
  • Feature can not continue without input -> modal
  • Not directly user initiated -> notification

Also I am not aware that we have any modal dialogs that should instead be notifications.
So for this exercise I plan to simply go through the usages of prompt api. I will list any questionable usages here.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 21, 2021

Notifications which might no longer be needed:

  • FindWidget @rebornix
  • Close Workspace action @sandy081 I think this action should be disabled when there is no workspace, so ideally this notification is not needed
  • Settings are automatically saved @sandy081 I think we have educated our users enough and I think the future is that setting do not have to be Applied. So I would think about removing this notification alltogether
  • Tests shuold this be an .error or at least a warn @connor4312
  • License @joaomoreno I think we can just remove this
  • Welcome @chrmarti this feels like it should use the progress api? And not notifications
  • Sync Sync turned on. @sandy081 do we really need to notify the user that sync is on, doesn't the activity bar badge update accordingly? Actually in this file there are a lot of notifications usages. If you think @sandy081 all of them make good sense feel free to check this off.
  • Extensions Install @sandy081 should this action be disabled if there are no workspace extension recommendations?

I have removed some notifications in debug and file land already and changed some from info to warn in undoRedoService.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 21, 2021

Here's a list of questionable Notifications which are used for user prompts:

  • MenuBar @sbatten we might be able to remove this since now the custom menu is on by default, correct?
  • LargeFileOptimisation @alexdima the flow here is -> we show notification with actions -> user chooses one -> we show another notification asking the user to reload the file. Could we improve this flow to just have one prompt notification which would just update the setting and automatically reload the file
  • Workspace recommendation prompt captured here "Do you want to install the recommend extensions for this repository" should not show up on startup #121802
  • Malicious Extension Uninstalled @sandy081 why would a user want to reload? If it is required for security we should use a modal dialog, if not then we should probably just use a status message to notify the user
  • All extensions disabled @sandy081 I think all extensions are disabled due to user action and then we still show this notification on startup. Does it makes sense to instead show a badge on the Extensions viewlet?
  • Formatter @jrieken The first .prompt should actually be a warn and the second one might deserve to be a modal dialog since it is a user triggered action which can not proceed.
  • Installation corrupt @alexdima I believe this should be changed to be a modal dialog, and to not allow to not show again. Since we do not really want the user to continue using VS Code in this state
  • Tasks @alexr00 I know you are removing old version of tasks, since you are revisiting that can you maybe review the usage of .prompt in tasks. If it is user blocking it should be a modal dialog, if we can get rid of it even better. This one looks like we can remove it once we have workspace trust
  • Localization @dbaeumer after a user has installed an extension we show a notification asking if he would like to apply and reload, since this is user initiated it might make sense to use a modal dialog. What do you think?
  • Trusted Domains @JacksonKearl so here we open the trusted domains editor and show a notification. Can we just have the explanation in the trusted domains editor and not show the notification at all?
  • Update @joaomoreno can we just use a progress service here for the prompt that it is in progress? That way might be a bit less obtrusive

@alexr00
Copy link
Member

alexr00 commented Apr 21, 2021

I removed the tasks prompt related to tasks v1 ✔.
However, I also added a new one to notify users that I upgraded their tasks from v1 to v2. This happens on startup, and few people will actually see it because of the low use of tasks v1:
image

For the automatic tasks prompt, I expect we can move that to a setting and not show a prompt once workspace trust is turned on.

@alexr00 alexr00 self-assigned this Apr 21, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Apr 21, 2021

@alexr00 great, thanks a lot! As for the the new notification it makes sense, however if the automatic upgrade just works I do not see a point in showing it. Though I guess it might not just work so that is the reason to show it. But in the long run (after 3 milestones) I would just remove it as well.
And yeah for the automatic task prompt - removing it next milestone would be great.

@alexr00
Copy link
Member

alexr00 commented Apr 21, 2021

I think we need to show something after the tasks upgrade. It will not be perfect, and the user will see that they have changes in their workspace when they go to commit. I want to make sure they know why that file changed.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 21, 2021

I have manually reviewed all internal usages of the notificationService. In the comment above I have listed all usages which I think should be discussed and maybe improved. For larger items I have created issues and linked them to this one.

I think we are actually not so bad in VS Code core, but I think we can still improve to be a great role model for our extension ecosystem.
I have assigned the owners to issues and checkbox items - thanks for your help!

@dbaeumer
Copy link
Member

@isidorn regarding localization: I am not a fan of a modal dialog here. Best would be to have something during install that lets user choose to automatically switch to that locale.

jrieken added a commit that referenced this issue Apr 23, 2021
@jrieken jrieken removed their assignment Apr 23, 2021
@joaomoreno joaomoreno self-assigned this Apr 28, 2021
@alexdima
Copy link
Member

I suggest that we also offer some kind of API which says "show notification if no other notifications are currently shown".

For example, here's what I got today. The survey notification should really not show at the same time when 2 other notifications are shown.
Screen Shot 2021-04-29 at 10 28 24

@isidorn
Copy link
Contributor Author

isidorn commented Apr 29, 2021

@alexdima good point, I outline the same idea in this comment #121802 (comment)
Though this holds particularly true for survey notifications

oxy pushed a commit to coder/code-server that referenced this issue Apr 30, 2021
631dbe250bc Merge pull request #122730 from microsoft/tyriar/121282
166d7fe44d9 Ensure inline action applies to terminal out of selection
921203d98a5 Revert "Use a menu instead of hard coding actions in tabsWidget (#122461)"
1ed6862c3ea more insights when execution integration tests fail
e1a46ca69b5 fix #122699 (#122712)
6449b6b7253 Fixes #122714: Guard against negative numbers around indentation
f2878212f72 Listen for workspace trust when upgrading tasks Fixes #122535
42cf2286c7a fixes microsoft/vscode-remote-release#4970
de6424abd01 remove workbench-web*html
a348d103d12 debug: update companion version
2a9f903edef Fix #122257
c67711fdde3 Fix #120112
f375f7e0aa2 Bumps RemoteHub version
74454818fe9 Use single quotes instead of double quotes (#122703)
78577aa18da Merge branch 'notebook/dev' into main
dd58b1fe2bf fix #121647
502ebdb1930 bump builtin modules
a7dcfd1e2c3 fix #122608 (#122616)
14a3cec0d4a Fix #122360
33a9b2adb7d Add missing scope to settings
24ea8408c3d testing: propoagate timeout option for unit tests
8dcc489fa1b Re-enables Git extension for virtual workspaces
03393445797 pass configuration in from processManager -> remoteTerminalService
e7c0af1137f Revert "Revert "Merge pull request #122540 from microsoft/tyriar/122104""
024251c2be2 fix #120848.
f0394ca9663 Updates endgame notebook repos
160b5509d2b re #120545
f9901cea702 Fix markdown cell folding issue Fix #122675
bdb2324c9da revert change to hide condition
5d5d7389888 fix #122334
ed52d777ef6 fix integration tests
1846aeaf8c7 testing: fix welcome view being shown if tests were synchronously available
62b609670ed Clear lastRunSuccess when clearing output Fix #122645
f5bef964648 change wording back to kernel, https://github.com/microsoft/vscode/issues/122415#issuecomment-829329529
6102a7d2636 Fix running
19c6d913ca9 Add noop command (fixes #122518)
df7aae61657 Add flag on whether a contribution can support a resource (#122658)
de6057e397e fixes #122656
439ec79e6be Fix #122637
3d6f88eb925 fixes #120828
2eb378324d0 fixes #121392
b2d6cab9985 Revert "chore: bump electron@12.0.5"
4b06c752c6a fixes #121425
ae82935e448 fixes #121503
7d51e0b1eb6 fixes #122289
d295d140849 fixes #122353
83c7bc3dbf1 allow controller picker with single item, https://github.com/microsoft/vscode/issues/122415
1cc7abafb0d Drive users to picker when having multiple potential notebook controllers, https://github.com/microsoft/vscode/issues/122415
ed5d4a1329a Revert "do not auto open pasted file"
3bb2d0c3a21 fixes #122354
7fa8cdf44ef fixes #122079
677be5b44b0 change vs select wording tweaks, https://github.com/microsoft/vscode/issues/122415
3162eac1f9b update distro
e6b871d094d show placeholder text for kernel picker, https://github.com/microsoft/vscode/issues/122415
eeceecef81e update doc
780eb163b7a Improve capabilities.untrustedWorkspaces contribution (#122603)
5682823e663 improve virtual workspace disablement wording
0123d26aaa3 tweak setting config
2f915a24b40 Don't label custom editors are readonly if the editor is not editable
28a1bc2f35e Revert "Merge pull request #122540 from microsoft/tyriar/122104"
3915fcfe493 Add some links and small cleanup for JS/TS settings
e8eb44523ef Improve auto-fetch setting display
a4fdb2c3ad0 Make adding overrides an preferred quick fix
9064c909d70 chore: bump electron@12.0.5
7adfba6262f Remove no implicit override task
60f46f2f7a8 Adding JS and PY Azure SDK packages (#122468)
f15ac1527ff fix unit tests for web
75f4c87a854 fix #122548.
c56f5ea118b fix #122359.
2858d5f3a75 remove trust from web
6a841dd8d5a Remove extra padding on h1s in markdown cells
40e0a578a80 Merge pull request #122505 from joyceerhl/dev/joyceerhl/markdown-cell-padding
033f6aac860 Fix missed Previewer.plain call due to adjacent @ts-expect-error (#121975)
f17e1ce19d0 Update distro
f8033ad59a2 xterm@4.12.0-beta26
3719898cb81 Merge branch 'notebook/dev' into main
bf7d8da5f0f Fix #122360
2f5e355bea7 fix #122329 (#122576)
968d6702663 testing: fix welcome view being shown incorrectly
7770708545c Reapply markup renderers change
c8c96aae9d5 Fixes # 122567: regex included .git in capture
5082e72921d Avoid cell execution icon flickering due to rerendering spinner
201063aa2ef Fix missing cell execution icon
d89a35b91fb API TODO
107351bc206 debug: use category instead of tag for search
82399e71c2d Even more port forwarding logging
29b49a03928 fixes #122520 fixes #122393
26ce0255947 fixes #122310
1bd250ca513 Set tunnel factory earlier (#122557)
a8a1b0f6db1 fix #122452
3b1b002b039 testing: mark runs complete if trust is not given
606bf316c73 Fix #122544
6f6b8156506 Call cell statusbar providers after changes are sent to the EH Fix #122341
99f8682e29a Fix inherited split cwd
5728f84b8c3 Merge pull request #122399 from solomatov/ext-host-hang
24faa3733fb Resolve profile environment when launching default
13d3c0e7575 Add explicit dispose calls for `DiskFileSystemProvider` in tests (#121857)
e2eb2ec0d75 Add enum descriptions to tabs settings
398a23805b3 Fix #122311
06694a8e577 Merge pull request #122540 from microsoft/tyriar/122104
36fe84236dc Rename hideForSingle to hideCondition
1e9c0a643e4 Fix notebook cell collapse action Fix #122318
935fb2b33c1 Merge remote-tracking branch 'origin/main' into tyriar/122104
1f913a81b16 Revert "better fix for https://github.com/microsoft/vscode/issues/119943"
134f551f210 Revert "remove unused code after changes for https://github.com/microsoft/vscode/issues/119943"
3ea6e11841a requiresTrust -> restricted
a9ad5d9eacc Reinstall sash listener after view swap
b3292e6fff7 Merge branch 'main' into tyriar/122104
85ed0a54d12 Fix #122543
aa1b82bf134 Fix #122477
05658fe91ea remove unused code after changes for https://github.com/microsoft/vscode/issues/119943
0877dc2131f better fix for https://github.com/microsoft/vscode/issues/119943
01a6c000ce4 Fix compile
10a5077e0b9 Bring back workspace shells via setting
c76579365d1 Fix #122533
5f9336443fb Task upgrade requires trust Fixes #122535
d0fceb64b42 fix disposal of extension-triggered document references when file is deleted, https://github.com/microsoft/vscode/issues/119943
8f45bda14f1 Enable some upgrade of tasks with global os config Fixes #122435
0be4e2958f9 Fix #122488
b98c1dd7eb6 Remove no longer relevant comment
d0d615d1e4c Improve plural language in task upgrade notification Fixes #122437
dc5219000dc Fixes #122333
636583b1cd7 Use schema version as task upgrade trigger Fixes #122442
a613882bbdb Task upgrade shouldn't stop if tasks.json.old exists Fixes #122439
e2044db595d Don't include empty arrays in task upgrade Fixes #122445
8420e94d8d2 fix https://github.com/microsoft/vscode/issues/122270
5688d75ef95 update jsdoc for NotebookController#viewType
232b10fb540 more jsdoc for supportedLanguages, fixes https://github.com/microsoft/vscode/issues/122372
5ba42fcf94d fix #122510
811416a13c1 Merge branch 'main' into notebook/dev
f608a090a6a make sure to return options from override handler (or existing options) https://github.com/microsoft/vscode/issues/122480
a6ec48d1597 fix #118423
84ef3183736 Add missing padding-bottom
08605e882e2 Fix #122256
38831ba3626 Fix typo
13f1afffab0 Make sure empty cells clear previous rendered contents
8d1794e91d5 Register config
5ce4e7ca8f3 Bumps RemoteHub version
f727e50c1a8 Use a menu instead of hard coding actions in tabsWidget (#122461)
1f165beac40 Fix unreliable status bar indicator Fix #121194
27b39a13a00 fixes #122310
75615b76275 Fix potential cell statusbar issue
779434d2d11 fixes #122306
ae1c315aa7b tweak wording for disabled extensions fixes #122394
bf7c1f53d94 use label service to provide tooltip fixes #122411
df3ebcc5ef2 use authors always fixes #122382
bea80413c2e add setting to configure trust prompt fixes #122304
782ec1356c0 Add build extension media tasks
b08c521660a Fix #122385
e8c5b7bb8bf Fix #122429
04e57de7248 Fix #122425
eb6a45ae94f Align single tab status size with tabs
aa454714b70 Fix status icon blurriness
db5a53958e0 Fix error message in case of activation failure
051c38cf0f1 testing: trigger relayout on welcome view visibility change
a50793147e6 Fix #122440
d93abcd3d97 Fix #122430
e106db06194 fix #122218
541063725ce update distro
f1c66b6f9bf Set aria label and include split number/total
40983b6a142 fix #122340
283c3035a49 fixes #121148
f4ab7e822f9 Fixes #122361 and 122360
19cda32aafc Another asWebviewUri fix, use the authority of the root that we found the file in.
c193a1ca383 Ensure an invalid icon ID is not used
f637c8fda56 fix #122150.
138be779f34 Terminate in case of ext host IPC timeout
a065a9458d0 Task name updates
912e8aff9c4 fix https://github.com/microsoft/vscode/issues/122328
3a8aefc8006 Use markdownDeprecationMessage
d3d2d113917 Add deprecation message to shell and shellArgs settings
0d5eb683ab7 Ensure tab rerender happens after layout
724172d1349 Show keybindings in inline actions
11a7f9565ea text files - automatically save when reopening with encoding (#122301)
b26b993dafa Make inline actions multi-select aware
87a33e998d8 disable edu telemetry on nocors
b9147d80e5a Set active and focus new terminal on double click
c50ab1e89f6 adopt editorOverrideService for compare (#121668)
3e1a7dc6551 Don't cache the text editor as it doesn't require the ext host
83581ff2b9e Merge pull request #121186 from microsoft/tyriar/ptyhost
f28947fb35f Fix compile
33be8b82f70 Merge remote-tracking branch 'origin/main' into tyriar/ptyhost
a6591d45e04 Add telemetry events for pty host
40c385c4498 web: use tmp as inmemory scheme
f92821bfa34 update distro
aac4cce13e6 Set focus/selection to new term on dbl click
4c24caf5d90 Add ... to rename and change icon
faf54e77e61 Remove console.log in test
dbb1a584992 Hide terminal tab hover on mousein, unless actions
eb141a80257 Use the latest LSIF version for indexing
f247d234d7c Use terminal groups for build Fixes https://github.com/microsoft/vscode/issues/122287
4550c3b454d can change enablement when disabled by trust
c9e8dff24c4 window.title ${remoteName} seems to be "vscode-remote" when not in a remote (fix #122213)
6ef53c31d9c shared process - also log lifecycle state when window errors
d417ef3e79f update distro
d74baa17185 log when using in memory data provider
e2e0d915729 Merge branch 'main' into notebook/dev
1f8e11079ea Revert "Comment out failing integration tests (#122269)"
0317e056bbb Merge branch 'main' into notebook/dev
26cf2a5d624 fix https://github.com/microsoft/vscode/issues/122269
2250b7aa3c0 :chore: allow to use node.js 16 for developing vscode
5346ab1bc3a Merge branch 'main' into notebook/dev
9a4d524f909 Comment out failing integration tests (#122269)
0cbc7217096 Bumps RemoteHub version
f88202aa46f Fix missing cell execution icon
8b22dff166d Updates endgame query
e3476ac1865 API TODO
fe7c5aba015 Revert "Better notebook markup renderer api (#121882)"
4a0a1f2f6f1 Fix replacement for script after it has been optimized
e95ce0a810b do not block webview creation for fetch errors.
fef89de135f remove open editor on startup
9b328b27396  NotebookKernel test, another attempt
98fdb8a9a06 add skipped test for lcs diff.
b1569995f9d testing: allow waiting for server before running unit tests
fc90674374e use parent folder instead of folder name
4cb27d2ec76 Better notebook markup renderer api (#121882)
495d162a4ef minheight
4f6b0a1b7c7 swap button and text
2be7cd82b0d cleanup styling and wording in editor
5c8ab73c2fb Build using newer TS nightly
bf339ba787e testing: allow contributing to test welcome view
6014c7781e3 testing: allow following running test
480f3c0b351 Return undefined if dialog is cancelled (#122234)
8b15a01d8eb [json] update service
5d4454709a3 Fix #122218
82520584efd remove unneeded logic
b466147ca4b fix #122161
e1845803d30 Add telemetry event for failed extension activation
2f946f7d803 fix test. @jrieken.
bf94540cc88 Merge branch 'notebook/dev' into main
893d29c487e Bumps RemoteHub version
553d92817ba Word selection is incomplete for C++ identifiers containing certain allowed characters. Fixes #121343
4f37102dc0a Fix issue with cancelling the dialog
ba7c9491645 web: drop authority usage
51b2521eef6 use prominent status bar theme color fixes #120455
cb7b2e8c375 fixes #120500
37d967e30d9 testing: rename testRunTask to testRun
b9b6a11be76 fix #118073
f6f81128192 Merge pull request #121938 from microsoft/alex/change-default-enable-builtin-extensions
5080d21c0b5 Fix typo
7b0a8177fac Implement workaround for jupyter in codespaces for asWebviewUri issue #121981
aed088f7016 fix #119678 Co-authored-by: Daniel Imms <daimms@microsoft.com>
7971891fa17 Merge pull request #122100 from microsoft/ben/search-editor-backups
c15cb13a383 Add js doc comments
7329a207e09 Merge branch 'main' into notebook/dev
8fa05403b6b Add a cache to the editor override service to allow awaiting ext host (#122067)
08e29e6e890 fix #121317
141c4274d90 update distro
b7e57b93f8f No longer force showing input box for screenreader (#122054)
205a366f1c1 Fix file location pattern in eslint-stylish problem matcher (#117576)
693e3a4aebe browser: register inmemory fs provider
f3cb718a800 more renamed
9a43ef93f70 extract INotebookKernelMatchInfo
db7b52abdc1 Undo task queue change
7135d9d5ea6 Bump ssri from 8.0.0 to 8.0.1
efa9e692e34 Fix narrow terminal tab alignment
25b4a53f67b Fix bad tilda handling in simple file picker Part of #121280
289d46f960d update distro
4212c6f9234 Remove unnecessary entries
c95aaf71a8c Add keybinding for split in tabs
91c41b04db2 Add keybinding for delete terminal tab
b57a9d16c93 Clean up IEditorInput#copy
25787c9584f Add focusMode tab setting
8fac1535178 :lipstick: renames
7a5031487a6 Remove short description for terminal split/kill
5bf77b350f1 Set selection to what is right clicked if outside selection
50b10894ce4 Merge pull request #122179 from microsoft/sandy081/custommHover
acc4bcebcff Adjust active instance in tab on dispose
5d77401e475 debug: restart should be sent to parent session
61472da358d Render tabs on tab widget create
42754baf3a0 relax uniqueness requirement for controller ids, must only be unique per extension, not globally, https://github.com/microsoft/vscode/issues/121902
57f1aa9ae66 update distro
0489b546826 OSS Tool
d90814dab4e make sure alternative goto-command is also a goto-command
5623111a12e correct remoteAuthority description in workspace files. Fixes #119858
0c4663383db Merge remote-tracking branch 'origin/main' into alex/change-default-enable-builtin-extensions
dcd5eaa0b56 remove todo
9129f217050 Merge branch 'main' into notebook/dev
ad372e2f94a more test fixture adoption
6c5613e6972 add test and fixes for https://github.com/microsoft/vscode/issues/121904
16423fad0b5 file working copy - actually use elevated file service
a2656e12606 add doc
ad16e7c2123 round pointer poistion
7c10c7e1e28 Fix remote explorer dropdown alignment Fixes microsoft/vscode-remote-release#4945
975e8ba2845 web api - move log level into new dev options
f52952332d1 :chore: some ReadOnlyArray => readonly
974d87948b4 Merge branch 'main' into sandy081/custommHover
7d13ce88e7f improve hover position logic
b8c9fbe5918 store associated notebook by uri _and_ type, send unselect event on kernel- or notebook-remove but keep the memento untouched, https://github.com/microsoft/vscode/issues/121904
f85e69f55d8 file working copy - write elevated support
594b7b07a6a make sure "Open With..." actually works..., maybe https://github.com/microsoft/vscode/issues/121974 or maybe https://github.com/microsoft/vscode/issues/121904
94daaf715a4 win/linux: alt+f4 to close window (#54492)
2cfe0d79121 fix notebook type bindings
5053c82843e adopt api changes
a15a6237c2f Merge branch 'main' into ben/search-editor-backups
d505f37758f file working copy - provide "Save As" support and address some issues
633562da380 Remove some finniky logic causing rendering glitches
2023dd3ce83 Fix #122090
0eccb45395c Fix #122091
7950d3e6210 Support multi select split/ kill in terminal tabs  (#122148)
9e9ad5b905f notebook.navigation.allowNavigateToSurroundingCells
08d37a85a3f turn markdown cell into preview mode after hiding find.
27388ab7cf4 fix output edit sequence.
25d716f9006 [html/css/json] update dependencies
cb6e7b383bb fix #122099
6c8875d8bb8 working copy backup - adress some issues before endgame
c2041ceed35 :lipstick: editor extension export
1a46de24eab Improve terminal text shifting when icon is resolved late
fd610ca54bb Improve rendering of very long collapesed titles Ref #119766
c67ea42a683 Restrict space that can be taken up by extremely long contributed items Closes #119765 Closes #119766
6ef0f2f1bd4 tabs.enable -> enabled
42851ddb80e Hide description in narrow tab view
7aab1c1714b Update tab sash reset to play nicely with new changes
8251c67121e Merge pull request #122076 from microsoft/tyriar/122010
cec1401b9b9 Fix compile
d7df6a7be04 Support new description in tasks
2c7604e4ad9 Add terminal description to single tab
14919db24dc Remove local title appending
2e191b55ae4 Add terminal local description/initial text
8a426385aef Close #120122
51ea16cd700 No more mr nice guy
47b7fd91d6b [Getting Started] Naming: tasks/items => steps Ref #120049
49ea5ccc13b Fixes #121873 (#121874)
a1d60dcb3bd return terminal icon if one isn't resolved
a87db274dac Make sure we build extension media for integration tests
d690b2d7e21 Fix notebook tests
3faf47d16ee debug: bump js-debug version
b126d45af96 Allow x64 macOS builds to be triggered alone
af58ea10fc1 Show trust dialog when running a notebook cell #118584
013521dd1e6 Accept uid=501(daimms) gid=20(staff) groups=20(staff),12(everyone),61(localaccounts),79(_appserverusr),80(admin),81(_appserveradm),98(_lpadmin),701(com.apple.sharepoint.group.1),33(_appstore),100(_lpoperator),204(_developer),250(_analyticsusers),395(com.apple.access_ftp),398(com.apple.access_screensharing),399(com.apple.access_ssh),400(com.apple.access_remote_ae) icon format only
be42b4b655a Don't autofocus search box in settings on ipad - #122044
3efe6bb4f94 Allow markdown content in getting started (#121960)
afaa4944045 remote indicator menu: cache action groups
aa219c8eb0a Merge branch 'notebook/dev' into main
a0804b66d3a fix #122049 (#122056)
b2c250faeb3 fix build
f0c8fea098d Tweak "switch to insiders" message
6d56e69ba93 fix #121954
b272df7ade8 fix #122051
a729f709a32 Refresh tabs on hideForSingle change
1fcbe3d71d2 update edit mode with source
9c6f4c194f7 notebook find with match count.
5c7d17bf267 Move service registration
3418b95ac34 Introduce copy concept to editor inputs Fix #121429
3b18aed03e7 fix #122039
6c747e75dad Workspace Trust Prop Changes (#121779)
ee3812f51cd fix #122038
d879960af3d send event when affinities change so that status bar can update, fixes https://github.com/microsoft/vscode/issues/122028
80b5eca3c1b add unit test to assert, https://github.com/microsoft/vscode/issues/122028
558b08e7905 fix #122031
fc19fba5ae1 Have single tab act like a dropdown
3cba3d9c4df Merge pull request #122032 from microsoft/tyriar/121601
838b1131985 Have single tab focus the terminal
b9f5e85bc07 Add context menu for single terminal tab
ef64d205b95 Fix missing cell statusbar icon color
89451c134d0 Remove todo
760b84e09f8 Namespace tabs settings
31c946b97ab Catch showTabs = true legacy case
c8807577d4c Hook up new showTabs enum
876dd2782a2 Don't allow multiple tasks runs to start at once Fixes #118238
803d0d62464 Add new settings to control visibility of active terminal
2a384630932 Merge remote-tracking branch 'origin/main' into tyriar/121601
9a978d2f31b working copy - implement backup restore in tracker and keep non restored backups (#117873)
338afacb02d Add additional height to term tabs for dbl click
25cecbe4be9 Fix launching terminal profile via dropdown
4827b266951 Initial single tab view
64f72f290a1 Bump distro
66f0c29ddb3 Fix spelling error
a8755553a71 show selected controller in picker, don't say kernel in the UI
0ee8f4efeda Update my endgame notebook
912259262bd fix build
d95f4c4d8b5 Workspace trust - multi-root workspace file (#121765)
5685e22ba3e Remove soft notification from extension enablement
e51f5015b29 fixes #111350
18c4196f82f Remove soft notification badge
122eac1d743 naming :lipstick:
118c41150c5 Move extension settings for workspace trust
fa0da8322c7 Further improve pasting into simple file picker Fixes #121280
a14e4d060a5 working copy - first cut of a backup restorer that works on new working copy editor service (#117873)
6a16dcf5867 Ensure tabs don't get another split added
f46cebe4666 sandbox - fix running in sandbox mode
cfb866ac533 Show tab actions on focus/selected
d40139dd638 Make typescript problem matcher even more general Fixes #121672
f37cda267a9 show in tooltip if controller was auto picked or not
4106ff45187 Localize empty tabs context menu labels
88e2f94a9d7 Add show tabs dropdown entry, remove others
43247e86159 Add the globe back to the Ports view
b8e2b1b7889 Merge branch 'main' into notebook/dev
68ddcf50e86 Remove bad } from terminal title
97814d10877 node-pty@0.10.1
cf603f67f05 Remove tasks from workbench.desktop.main.ts Part of https://github.com/microsoft/vscode/issues/118201
ef521cc5403 remove bad instanceof check
2437313ca46 Fixes #121535
ca36916a61a update distro
8e0e2199b16 working copy - drop TestWorkingCopyService
abe5e414e70 add onDidCreateNotebookDocument in addition to onDidAdd.
d1b0a469b12 remove kernelProviderAssociations but add a notebook-type 2 kernel association as shared/sync'd memento
05e0899ffd1 working copy - more readonly arrays
52ef3b65268 Pass correct URI to opener service fallback Fixes microsoft/vscode-remote-release#4920
31536dd690c editors - make findEditors more powerful
c32f1cc4632 update ref viewlet
ac151b40a57 enable virtual workspace capability
77ac0dc1a5c Merge pull request #119040 from jeanp413/fix-103631
9701c057ef7 refine prompts: using warning when file is too large for formatting, use model for installing formatter, https://github.com/microsoft/vscode/issues/119463#issuecomment-825434820
a668bed63ae add skipped/failing test for https://github.com/microsoft/vscode/issues/121994
abc6cf94729 text file tracker - fix regression with untitled not being tracked
666f3ac3e06 file working copy - provide some basic save error handling (#117873)
0310f02dc5d reset key on focus out and set focus if there was one
4853ea69eb4 Add command and keybinding to focus terminal tabs view (#121978)
66fd0cba91b Enable noImplicitOverride
36591a96a02 Rename
cd9a6a48201 Add telemetry for rendering of markdown path
1ea93521feb fix #121816 (#121957)
afdd217b3bd Create new terminal from profile in multi-root workspace (#121958)
7bf7774d8a6 Add custom editor telemetry
b0b4b814d0a Fix #121793
1b1fa411580 :lipstick: test
274565432ce Merge branch 'notebook/dev' into main
94f28728f76 remoteIndicator menu point: double digit order number. For #121180
c141ca66619 testing: show load errors in tree view
214a1581b7e Make window indicator menu contribution point stable. Fixes #121180
484c5c87338 Fix tests
8e51485f45f Debounce cell output edits from EH Fix #119832
ddbc369b115 Fix cell output append edits showing up in reverse #119832
2f077172cb0 Add `php.validate.executablePath` to restrictedConfigurations
dfd1b65fce9 debug config manager: dynamic providers fix
894f50d5443 debug: make sure to not show dialog when launch config content is being created
b1ca80cf60a re #121140.
2d12c84be75 fix #121723.
1f75a0331bf Make narrow tabs show status color icon
aebef8cf5b7 Fix statusbar items with wrong width in new cell
7c17ed4680f Fix #121927 Remove new inner span in statusbar items, also switch to just codicon syntax
ab9a916272c some :lipstick: and a tricky todo
426f1b7d80c Fix layer issue
b6ff982121d Merge branch 'main' into sandy081/custommHover
9f43daf9028 use DAP 1.47.0
df42794a6c8 node-debug@1.44.27
5460fcfc4ea Support relaunch hover action
2130042ca4c disable github extension in virtual workspace as it depends on git
e1bfeec6b1a Show relaunch needed details in hover
f38f90dfe16 Improve package.json file check Fixes #120279
f68a7e77788 add NotebookDocument to executeHandler
690c76c1051 Fix statuses getting stuck, integrate decoration title
5fc245f2d74 refs #120675
a217409e38f include silent for notifications:actionExecuted
f6c4607367b Incorporate task upgrade feedback
68bed019705 adopt virtual workspaces - not supported
d4033de1f1d update distro
ed16789225e localise workspace trust strings for exts
97344537a59 Use affinity over priority
1305c61d823 Merge remote-tracking branch 'origin/main' into alex/change-default-enable-builtin-extensions
a385ea15bdd todos about affinity vs priority
5390ec0e7c3 remove isPreferred as instance property, replace selector with only viewType, allow controller to set a notebook priority instead
5c39e705cc7 Add tooltips to terminal statuses
b14455b318e Provide label formatter for terminal URIs
daab26c2e71 Merge pull request #121853 from microsoft/capabilities
70c5e1e00c5 fix compilation
07505af8c9e update distro
793cdaea1f7 Removed unused code
7ac3721a4d0 Hook visual bell up to enableBell setting
e90519d1cce Rever awaiting for ext host on open
1eb45d72c8a Delay terminal bell shortly after creation
3ebd601face Change default for enable builtin extensions
0cca69109c4 Ensure primary status event fires when status is removed
436725c584e Use Application scope for `keyboard.dispatch`
c95c0cbae49 Add tab view empty context menu
6779f853214 add comment
371b3de4367 Fix right click pasting in tab view
03a3abf6daa Use constant for dblclick
b64f1aa2358 Support double click to create new term
522062daf57 Expand terminal tabs to whole width
9fb92f0f705 mark property readonly
dab0e063bcd mark supportedLanguages as optional, some todos
166efae3664 Fix `--noImplicitOverride` problems (#120675)
6a781878370 Remove deprecated sync methods from configuration resolver Part of #108804
87eac45476d Support defaultProfile in selection default profile command
253fee71631 assert that executing a cell send selection event, https://github.com/microsoft/vscode/issues/121904
90c5c7a0d2f Merge branch 'main' into capabilities
56acb0b1d25 Throttle calls to spawn/kill under conpty
bceab04077b debug issues should get auto assigned to me
12741ed7d88 add notebook instance to interrupt handler, https://github.com/microsoft/vscode/issues/121912
b96d65b9be4 Finish adoption of IShellEnvironmentService in terminal
5c904937545 Fix case issue on Windows with variable resolving Fixes #121847
2a6703463d9 Update distro
5a78d3377f3 Merge pull request #121918 from microsoft/tyriar/120328
7bd176faa1b Adopt bash terminal icon
4ae4ca97598 Move dropdown with primary to base
1df9d8902c1 send controller selection event when selection knowledge is restored from memento, https://github.com/microsoft/vscode/issues/121904
e86fdc6728e Merge pull request #121732 from microsoft/tyriar/121657
22d2f01347b Fix compile
fd709cc79fa Reduce calls to getShellEnvironment
eaf3a5dcda4 Move off deprecated resolve function
ae50493e894 Only dispose on middle click
29ade591f55 Remove old prompt from tasks service Part of #119463
dc589f540ab Merge remote-tracking branch 'origin/main' into tyriar/121657
00e8e6459d2 fix UntrustedWorkspaces type
5d8f09d2708 adopt to new capabilities api proposal
f5b31e9a331 use UriComponents for extensionTestsPath. For #121734
af76d0cf137 export IDevelopmentOptions
79033ef7a19 Adds code lens on vfs files
46a25f25e87 update distro
8ce16487193 Merge pull request #121734 from microsoft/aeschli/testsInWebEH
71b23eb39d8 Merge branch 'main' into aeschli/testsInWebEH
b3151c10ce7 fix compile error, fyi @rebornix
a18d061b009 Merge branch 'main' into notebook/dev
2e0214b3645 rename ExecutionHandler to ExecuteHandler
7ce1499d954 More removed unused
60af02d7582 fix #121807.
27675a99be1 Remove unused services
49924bbab74 Remove notification ref #119463
4a8e9493472 consolidate tabActions code
f547ada6eeb Allow text search providers to give messages (#121528)
159d5d2799b move separator inside
a536ece09f7 add hide tabs panel to context menu
807ae1e167d fix #121744
79a5cd28cae re #121252. Add actions to toggle cell position.
c638290c09a add setting for specifying cell toolbar position per view type. fix #121252.
6c48db1730a testing: fix test failures
883424c4e37 testing: betterify view
57d4e39aebc Fix issue with tabbing out of outputs with iframe webviews enabled #119727
7c83a16e724 Fix tabbing into statusbar, #119727
a689b7ec842 Remove underline from h1s in notebooks
15110d66f0d Bump fallback version for webview contents
7e8193bee0d adjust hover position for panel
d2b7b09d716 show panel hover on top
fbfe0154989 remove NotebookTextModel._mapping.
9e29a9caf53 align left and right positions
61364b04926 introduce hover position and align hover and pointer
306f32b7ce5 re #121869.
dd2aefcd7cc fix #121818 and make terminalService manager/updater of available profiles (#121837)
264ccd16d4f Merge branch 'notebook/dev' into main
2a718949839 update distro
0867628480e Merge pull request #121836 from microsoft/tyriar/plus_style
2ae89029880 Update Codicons: update "copy"
951612b9339 Remove deps from dropdown with primary
6344624354d Await extension registration fixes #116259
cc66860c669 Add styles to dropdown.css
39c0b817706 Update Codicons - Add "wand" - Add "debug-line-by-line"
a509be4c994 Update Codicons: Add "filter-filled" https://github.com/microsoft/vscode-codicons/commit/cdceb9f5fc38387c5c7dc3535bc6b528cd9cd4e1
dc0b17b5bfd typo
eaec4b3f2cd workbench embedder API: developmentOptions
731402dce22 async override -> override async
190e902afe6 Move editor associations to override service
685147c008f show hover pointer
9d0add77827 Update Codicons - Add "swap" - Add "copy" - Add "person-add"
2e5ca55a78b Update Codicons: add `terminal-bash` https://github.com/microsoft/vscode-codicons/commit/678b2158feae3d346916fd0a5db883c499376e5a
74cba9e0038 Move IEditorOverrideService to common
d86ba38b9eb Clean up cell margins
10afe5984ae Fix dragging cells near the execute button Fix #119535
07ebcc8d0ac remove virtual workspaces until onboarded
f9fc28d47db update ext manifest schema validation and built-in exts
0d29a8722c1 Revert "Move editorOverrideService to common"
6009275300c Don't lose cell toolbar when expanding the dropdown
c3265df7cc1 Show cell toolbar when hovering it, when it's invisible Fix #117618
84809f41cd7 Move editorOverrideService to common
4eee5c6ee5d testing: fix test wrapper not including ranges and not dealing with sync discovered root
3c4b64079d3 Logging categoryDescriptor.id instead of [object Object] (#121850)
301d4e9a50f fix broken test
aec0921e5c2 first pass to update workspace trust to capabilities
43d2efaab63 describe the context key for workspace trust
a9f70f7919e finalize basic workspace trust api
d97790d1624 Fixes #59 https://github.com/microsoft/vscode-codicons/commit/6c518bd9af3935deecf24ef31a55194598e98349
fa96e5566b0 Fix setting sync button in Getting Started.
aa6e570a848 Fix typo
0aad5f2390a fix #121841
3fe2d3b5433 [remote] Allow to open remote files through vscode://vscode-remote/. Fixes #108257
ce63fe5e18d correct name of initial dropdown
4af696b7892 Improve new terminal dropdown style
dbac9179a0b Merge pull request #121831 from microsoft/tyriar/121827
7623d09e3ae Remove tasks v1 Part of #118201
4a5c0bd88ae Don't expose change icon instance in command palette
27d236fec1c Inline menu entries
128c666879b Don't override keybinding for split
827d9284bfe Fix change icon/rename ctx menu
84e63b1d13f Create new command IDs for kill/split instance
f9737367372 Revert "fix #109765."
fd88b56ab91 improve messages, web: showSaveDialog
f80d55121f5 web: pickFileToSave
091b1f5a6ef web: showOpenDialog
9784c7a0efa fix compile errors
e2c97039958 prefix api object with api-prefix, like apiCell
e468d47ed84 some more API todos
415a43f04dc Remove has text log
37789e46950 Remove logs
28fbb99921c Merge pull request #121774 from microsoft/tyriar/121483
13302253b56 editors - respect override option in openEditors
034157dea81 gh auth: back to prod auth
e6a70813331 Action feedback
5b7a28c43fb text file tracker - open editors without going through override
a165ee92c50 Remove old new terminal panel action when showTabs is false
1efbb32036a editor service - cleanup isOpened()
14720cbc524 Remove configure term, replace with change icon+rename
74fc96f8491 rename IMainNotebookController to INotebookContentProvider
61baba1f583 remove some more kernel leftovers from notebook service
010267d7376 Handle cwd inside _convertProfileToShellLaunchConfig
16921f35e34 notebook editor status must listen to kernel instance updates
e09f0ecfcfc editors - require typeId for some methods that are otherwise unspecific
e3df15418ef relax NotebookCellOutputItem and NotebookCellOutput, e.g. don't enforce the member to be readonly
c1549ef877e sktech NotebookEdit ideas
7194c24dad9 use serializer in NB integration test
9af75c08c5b remove ability to alter notebook output via WorkspaceEdit or NotebookEditorEdit
4f9ac638ffc extension contributed kernels fall back to all languages when supportedLanguages isn't set, https://github.com/microsoft/vscode/issues/121329
832a699c00c move keybinding label computation to activity action item
89684626f23 editor service - :lipstick: API
e350c258dbe fix build
d60dbbf646a gh auth: fetch json
186897d756e distro
0c723c1bf37 tweak kernel sorting
9e8377d8cd3 TestWorkspaceTrustRequestService
3668a573adf gh auth: fix staging server selection
479a2247416 disable compare action when no active file, no need for notification
853f9171901 notification updates: #119463
141ecfb7981 mac specific actions should not respect web
820e70a460a gh auth: don't reach out to product.json
3236b8dd707 Revert "Enable the notebook renderer on web"
9bacf617b24 Use clearer variable names
5c3383251a8 unique working copy type id, stricter view types
625dcc34122 add enum-set for alternative commands and check the command type is a symbol navigation command
07013ef4a33 update ref viewlet
fc191749834 Move quick pick into editor override service (#121666)
7095f4706c0 unit tests (electron) - avoid sending circular structures over
2e79d9e362b Merge branch 'main' into notebook/dev
23a2409675b Update debug-auto-attach ext icon (refs #81760)
a72b1574b33 Double click on the middle part of a collapsed cell should expand it Fix #119777
65d1d29f7b4 Remove unused statusbar styles
e815d287851 fix #121655
27cf6a38076 Implement workspace trust for php-language-features
643756788f7 Allow running builtin php validation with a relative path configured to the php binary. This was previously allowed, but the fix to use 'which' was too strict
609e717d750 Merge pull request #121704 from microsoft/merogge/menus
21ae0ca0d45 fix #121736
91ee63fd0a0 Fix missing run buttons Update kernel context when editor model changes
64282aa6b7a Use new cell statusbar for execution items. Support color and icon info on cell statusbar items.
bc8c79c8f2c Fix missing run buttons Update kernel context when editor model changes
e23c988571b remove custom metadata internally
1315dbe4951 remove breakpointMargin internally.
b7d27a057d1 remove cellEditable internally.
7947c4d3f88 tweak split view width work
158ba0de72d fix typings.
1eb2a93ef39 fix #121631
e986377a625 move NotebookRange.
17fa3235965 more jsdoc
1d951484ed4 testing: bump distro and make document polyfill work again
8711b2dc92d remove deprecated transientMetadata.
2da00961559 remove deprecated custom metadata.
c67ac5d0830 Remove path from github-authentication
1d54cdf54a1 Avoid extra call to reveal if the editor is already active
9b8d52ded35 Fix calls to reveal for webviews that are inside of diff editors
24c6f586ddc Add requireTrust to comments.openPanel setting
7c486f3a693 Merge pull request #121758 from benmccann/patch-1
7d9dcaca452 Enable the notebook renderer on web
7d45a4503a2 Allow ThemeIcons to be used as decorations
3b20d95b3ad Consider updateOpen as signalling that project loading as completed
0642a7c299d Update debug server ready ext icon
851613fe478 fix unit test
ce91f3a00ff fix unit test
61f646674b0 Merge branch 'notebook/dev' into main
7b23ff442e1 more staging detection (#121769)
ad3e7ea1c06 gh auth: look at staging query param (#121768)
efe612365f1 feat: add support for additional surrounding pairs for markdown (#119982) (#121698)
ac48f78dd64 Add icons for built-in extensions (fixes #81760)
c32f4d0afd1 Make collapse/expanse cell actions apply to all selected cells
1764fc81a8c Add requiredForConfigurations for TS
ae24966cce1 Localize workspaceTrust
b9c647ab3f8 get rid of instantiation service
3737f9eacff fix #119866.
a818bda1aaf fix #121288.
3b3ec496f60 Adopt terminal ubuntu profile icon
3a862c2f7dc update wording
704f85a9db3 split, configure, kill for the focused instance
0772410c7d5 initialize installed extensions before starting extension host
3099237dbaa Max item width, style fixes for status bar items
cc850ade50c Cell statusbar test
b286729f356 Test cleanup
637403c1d57 Fix issue number in comment
4418386c13a Remove 'requireTrust' from search.exclude. Searching without excludes in an untrusted workspace would not be useful
1e6315f7059 Update Codicons: Add `terminal-ubuntu` (refs #121737) https://github.com/microsoft/vscode-codicons/commit/98b2fc81360d59ca195f00c16ff984121d4fe255
1c726074ec0 add jsdoc for NotebookSerializer
66c8a845474 Revert agent pool name
b62af979828 Update build agent pool
6473cab2d34 add some api todos
94589129a2f Add experimentation service to github auth extension
008c20865ec Intermediate content for Getting Started (#120602)
eb45f2bd17e Override original agent again (#117054)
e324e19e96e add a comment
390d4388c6c only fetch the profiles on window reload or if config has changed
666a6e8896a pass cwd to convertToShellLaunchConfig
d3245fbf024 remove unused, make convertProfileToShellLaunchConfig public, rename MenuId
9809e3f12ff WIP style updates
bdf2ef774e0 #118731
faec962a3e9 more removal of unused interfaces
01b1689c1e9 fix comparison bug when updating kernel bindings
d9e4b98387c simplify notebook kernel service
f7b69ef7045 Add keybindings for navigating terminal groups
61017718099 #118731
82357d5d4c0 #119110
0922dbb475a Move vscode-windows-ca-certs dependency (#120546)
e838389be00 Update distro
03a096326f1 Fix binary mouse events on remote
5fa2193ba78 add extensionTestsPath to IWorkbenchConstructionOptions
454b741257f restore integration test
45e013b704f Merge remote-tracking branch 'origin/main' into merogge/menus
e791f6b410b Merge remote-tracking branch 'origin/main' into tyriar/121657
2447e78e687 Implement sash reset in terminal tabs
b2b45e1005f execute by cell-handle, kernel manager has only execute/cancel cells, also "fix" isNotebookCellData fyi @rebornix
74bbba9aa66 Fix compile
e9b2d57825b Middle click on terminal tab to kill terminal
6170715c03f Fix fallback profile using --login on macOS
d4a6400596f Merge branch 'main' into aeschli/testsInWebEH
064ead50123 notifications - properly hash resource
0b46219a2d6 move "execution" of markdown cells closer to command
514d136bd02 adopt typeId for simple notebook working copies
79d748989e0 some jsdoc for NotebookController
438cdf9232d remove unused NotebookCommunication interface
47b406c8227 Merge pull request #120359 from solomatov/optimized-memento
be6a9027041 notifications - introduce ID property to help detect duplicates better
3abadabac87 Merge branch 'main' into notebook/dev
b06388f501e Merge branch 'joh/clean-kernel' into notebook/dev
fe7951dd7ab remove kernel provider from core, adopt kernel service, merge kernel2 and kernel interface, extract context keys from kernel manager, make context key manager only for execution/cancellation
40c99293c86 Try another fix for tooltip on safari Part of #111756 Fixes #121684
3a7cf0c9dc0 debug: update wording for safari dialog
1a74d20b2a4 file service - add test for `getProvider`
10b35b6aa2c #118077 remove hover background
a5b19b6f641 add supportsVirtualWorkspace to schema
b4816cfd1f4 fix tests
e74712bda17 fixes #118731
319d1511382 #118077 move custom hovers behind experiment flag
fa602ecdc37 extension tests - stop automated opening of devtools when running out of sources
1f9e039a11e :lipstick:
ab27efcc9f9 use new types for browser fs
a09354329b8 exclude htmlfsp from monaco
eaabe284856 Revert "Revert "use dom api to resolve file schema on web""
193d5d2c5e6 revert unneeded change
e2d0668ffad get rid of tabsWidget buttons
bd0d9341399 improve styling
6491f003c7d stylize
53ca9ec8afa refine conditional
0db78a7d563 only re-render dropdown
29a726f400e add comma
c0d4b45306e Merge branch 'main' into merogge/menus
fa9e3a81c17 resolve disposable error
6de1a8b7b8d get rid of register
1292b973d09 Revert "use dom api to resolve file schema on web"
a4b13e3fcf7 Bump distro
909f03eb3e2 Adding a few more override specifiers
65273f89bc1 fix output max height update for diff editor.
8fa6582b834 fix diff editor output width/margin.
e5c466f587b markdown-language-features: Fix Windows Preview Link Uri (#120090)
25b47bb9571 Use ctrl for add to selection on non-mac platforms
e62f21f40cc Remove extra await
f47e207f915 style buttons
1dde9302af4 get profiles to appear
f26ca76fb62 fix #121623.
297ac839dca replaceNotebookCells with range.
87c10dba596 Protect against exception when initializing terminal tree
e382db30892 Improve terminal tab setting descriptions
ef0942ba058 Don't throw exceptions to the extension when an outputId has been removed Be sure to emit events from applyEdits even when an error occurs Fix #121687
427ab0079f4 clean up
891683014c8 Allow svgs inside iframes inside webviews
1845ee08b84 Allow specific command uri in extension editor
180f95fa222 Merge branch 'notebook/dev' into main
ea5434ca544 node-debug@1.44.26
41d0782edec resize when tab location changes
d6ddd5866c0 use dom api to resolve file schema on web
f6b293d318f IFileService.getProvider
288368cdc05 add @types/wicg-file-system-access
8215a110a94 fix: build
6df31c584a1 trust: make workspace trusted during unit tests
b0eff48b18c testing: adopt workspace trust for testing
94894dfe7f3 Close #121395
caaa44b7aa7 Update aria label to include codicon names and wrap in spaces (#121496)
8f8407812bb add CombinedButtonActionViewItem
9dff5e0e014 debug: workaround to open new debugee window in Safari
3a3864174e2 trust: onboard debug land to workspace trust
f937a28dd0b Move scheduler initialization to the ctor
7635c6504d0 resolve -> reject
6330a7a728e Addressed code review feedback
b4b2d40adf9 Addressed code review feedback
03666a06804 Cleanup redundant code
c25aa77e336 Fixing linter
59ce58884eb Fix linter error
a502d34d923 More effecient handling of changes
d415fc0d0e3 adopt notebookSelector in status bar API.
9e323dacff3 fixes #121621
68362616637 Adds workspace trust setting
86157f0d557 api resolves immediately trust state in non-modal
f9db59cc755 update jsdocs.
dec167076bf Remove code related to dangling files
d7f19966a49 Fix #121289
3b8bfe8cee6 setup menus
1cafce9f5be DAP: new option suspendDebuggee on disconnect request
cdb8d62f088 Ben/workingcopy typeid (#121646)
4dde01fe34f backups - some more :lipstick:
500b051842e Fix #121506 @joaomoreno - Seems typo
11c3ba58af9 remove NotebookKernelProvider API and its implementation
05fa4efaec7 show disabled reason for extension disabled in virtualws
8f67a43aa28 web api - remove types that are not exposed in any API
5efce0f7e03 fix tests
5dbb0cc89aa working copy backup - more tests
7e22b12c4d7 fix build
2ea7d9c65f9 Merge branch 'joao/fix-120696' into main
3606317e4bf add test for whenTextEditorClosed
b89cb3dccd2 Format code
92b4126f276 Move workspace trust code into ExtensionManifestPropertiesService
401554bc451 change property to supportVirtualWorkspace
bfe28fa0962 implement workspace requirements for extensions
47231d090d3 adopt trust in github
f9fec24b452 make INotebookKernel2 extends INotebookKernel
b0ac820e347 working copy - do not allow VSBuffer for backups
1268f86ac7d add common.platformDetail in telemetry (#121264)
a8f860beecc remove window.sessionId
12aeeabdb5e more working copy backup cleanup
9da5986f515 Set default tab location to right
030e33ca8eb working copy backup cleanup
ef569a6e08c enable noImplicitOverride in our codebase
693c0e3e1da text files - add a getDecodedStream method
14981ce89d2 tests - enable colors for windows (CI supports it and the new Windows terminal too)
6b9bd78998a add NotebookController#detail
058552963b7 Merge branch 'main' into ben/workingcopy-typeid
cc778d679fb Merge pull request #121396 from limitedmage/suggestrace
0595da6b543 Merge pull request #121511 from gjsjohnmurray/fix-121509
b0d5ab6aabd :lipstick:
8aff878db25 Fix typo in map.ts (#121279)
2288da484db Bump ssri from 6.0.1 to 6.0.2 (#121576)
200d4c77619 tests in web extension host
73c85159e72 change extension kind controller to a service
367c11f77b7 File gets garbled characters when restored from backup (fix #121347)
e5d6ff4c06e jschardet 2.2.1 -> 2.3.0 (#121575)
e877b8062de backup - change to a buffer format (away from text snapshots)
2b44820d337 windows - fix tests
8e43ae3087e Workspace trust - merge storage and management services (#121540)
085df87b3bf working copy - extract a workingCopy.ts file
e1727abb411 backups - rename to be working copy related
99075a46ec3 Merge branch 'connor4312/test-api-refactor-application' into main
6360146a419 backups - introduce backup identifiers and adopt
92b5ca6d968 testing: fix error for synchronnously discovered tests
5624d860cc5 Further tweaks to grid styling
db221b816d5 Revert "add description to statusList"
34bdd983e21 Update renderings of getting started items based on overrides
d7f55753675 skip failing test
45e308fb286 add description to statusList
fa0cd78f7d6 Dont clip steps unless needed
bb3ea733def testing: rework running side to new apis
5b5320b7d5a Remove onDidAddTask - categories now immutable
522b60a1979 Fix bug where tasks could not be opened
e5295350a09 Close #119964
0767f255d2d comment out tooltip causing build issues
c0e29b7d2dd show separator in filtered quick pick (#121075)
a9109869988 fix #121509 documentation error for two API command results
1845b9d2a52 Merge branch 'notebook/dev' into main
85ca912f72c extract NotebookDocumentContentOptions viewOptions.
c657cdbef30 avoid stripping custom data.
bbcb45cdcdd use label instead of a custo name in terminalDecorationsProvider
95cc902f2e1 try to fix the build
a37a8c517a3 Revert "Revert "Don't block svg loading inside of iframe based webviews""
f8bc55fd267 Remove unused
8706813cdf3 Set max tab view size of 500
23ac9b5184f Fix showTabs NPE
a3ac715bfb5 Set correct layout when turning showTabs on
29b621b47e8 Fix exception when loading with showTabs = false
1f544741220 Hide dropdown when tabs are showing
557ac0b24bf debugAdapterManager: update wording
186bced5aa1 Remove Task prefix from tabs only
2102600c561 Reduce min tab size
d2961b4c081 Remove extrenuous injection
8217e20a706 Make resizing smooth
03aad7bb2db Prevent wide tabs from being centered
8f70a2d6ac1 use language name for labels
8fec10e2516 Focus newly created group ref #121395
4dbad29ad41 Change configure terminal to pencil
8eb52dce857 Fix warning status showing up when env var widget is on
8a67dade9ea Make status decoration padding consistent
b97977ff55a Fix exception
a3d61cb0251 Add change icon/configure terminal action
0b9c11a49cf more binary editor cleanup
0e2d23ec434 Remove * as platform from terminal
b46bca09d52 binary editor - remove file size check (fix #121301)
19b577164e8 Update distro
8d234a4dc9d Merge pull request #121176 from microsoft/tyriar/shell_resolve_refactor
9d72785a2a6 Merge branch 'main' into tyriar/shell_resolve_refactor
067f60cc403 Merge pull request #121330 from microsoft/merogge/terminal-status
8bcc74944c2 require trust for cfg vals
27539a2ef78 tweak conditional
59963d0328f Make error message clearer (#121339)
f206da596e0 modify conditional
7c7c83e5644 Update replacing editors in editorOverride service
5138a81c177 🧹
3fb483e7fff chore: bump electron@12.0.4
880363524f6 Fix #120202
972978848e3 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
93cf9f231e2 Clean up
6b7a55444a4 update configuration scope for tel,exp cfg
3595082e7d9 Address comments
5971cb68edb Fix race condition in suggestWidget
2c631534503 Revert "Don't allow multiple tasks runs to start at once"
b4dd497b275 add scheme Co-authored-by: Daniel Imms <daimms@microsoft.com>
30ae7bde852 Respect resolver's trust options
78872ce6113 Smooth the flow of installing new debuggers
d66d3929174 only register workspace trust request handler when trust is enabled
e4428f18335 revert change to a line
3e8b31b3947 Bump distro
7c7c0b7ee62 remove unneeded css
bbc5a53ac5b Try out another possible fix for safari tooltip Part of #111756
fe6850d4e73 Change default port setting value instead of setting Fixes #117189
5523c825ad2 Disable pre-resolving icon in remote windows
5029f1b18b4 Update distro
328937e7b64 Use OperatingSystem over Platform in terminal
f48845c4451 untitledHint: respect editor font
4430569ad07 debug session: pass configuration as args for restart
f4b60835ea7 Fix tests
c7d26be9a5c Disable terminal workspace settings until workspace trust is on
e077071ade6 Update distro
a79c0b09492 Update distro
5d72ea7c196 Add more top/bottom spacing to features  boxes
f31f60b7aeb Pass remote authority to context methods
93dbc7ac44c remove NotebookControllerOptions and simplify createNotebookController-signature
aa6ae6b4193 Pass remote authority into resolver
5619daacc25 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
27add7e2ac3 Merge branch 'lszomoru/workspace-trust-loose-file'
9e77384443c Resolve default profile in remote slc
3bddb9636c3 Fix compilation
a76a1efe043 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
e49f95b5315 More removing workspace shell permissions
61556099dd6 Remove todos
96065290c8c Update distro
3ae9ec00516 Adopt requireTrust in terminal
3c0e4897460 Don't allow multiple tasks runs to start at once Fixes #118238
95932045c7d check that notebook controller are unique per id
949639b9424 use default some delay
17cec8c0089 Fix ~ with fill path pasting in simple file picker Fixes #121280
1f941f612fe Fix #121456
aeb9b2051c2 Remove only
0358f147137 Fix unit tests
ba5e81ab093 Fix import
31016ade1e9 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
bdd072e51ba Add trust prompt
217359a80d2 some jsdoc and relaxed NotebookRange
ce791d27dc9 Fix #121362
564bcfe4cd9 render tree on trust / trust settings change
ba531de1988 fix ExtensionRecommendationsService test
bb43ee61909 Fix #121297
98f69856ea6 extract types for execute/interrupt handler, interrupt in not per document but per controller
9699bd793ce Smoke test fix
1f385f70e6e reduce usage of extensionDevelopmentLocationURI
c074bf897c0 make preload a creation argument, no editor needed when calling asWebviewUri
5ef190e98a4 Fix port log line and add regex check
fd7cedae033 :lipstick:
7668affd16b Merge branch 'main' into lszomoru/workspace-trust-loose-file
8877d8ca941 hook up execution task cancellation from controllers
cfdce942776 #116731
644e1d0bc42 :lipstick: in notebook service, also make sure to clean-up editor contributions when disabling/enabling extensions
42e271dd2e7 do not show dialog if workspace trust is not enabled @lszomoru FYI
ddbc8ae408c fix remote integration tests - do not show trust dialog when change is coming from cache @lszomoru fyi
a387125e199 Merge branch 'main' into lszomoru/workspace-trust-loose-file
3ac5ff11b6a Merge branch 'main' into notebook/dev
3c31f0903e4 move workspace trust service out of config service
b7ba430dcee Begin to allow extensions to contribute start items
55b2ab7fa4b re #121329. NotebookCellExecutionSummary readonly properties.
4db99a10b86 transientDocumentMetadata
8629b48030e rename transientMetadata to transientCellMetadata.
881a304efe9 Add some NotebookCellStatusBarItemProvider jsdoc
a7c67442b97 Clean up cell statusbar keybinding tip placeholder
7193b08f344 Remove old cell language picker item CSS
402c9bee093 always show intro modal
e7004428b7e update todos.
7cccfd1d43a Merge remote-tracking branch 'origin/main' into notebook/dev
d85b11a2ac4 use terminal service's instance status changed instead of instance.statusList.changed
d0a23bb0667 revert some changes
dedc2d1150c Add other platform settings
8859256f866 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
03333c995e7 Resolve icon in terminal asap
da16f9bef17 Move cell language picker to statusbar API
d87ab38a497 only show widget for manual relaunch
bd493ff734d Reduces validation timeout
ba4954af208 Ensures that the validation message shows up
0f890eeb173 Calls focus method
155df27d8dc :lipstick:
9f027210ce3 Update distro
a1a9adb9176 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
a6b849a8f9c Use icon of default profile
28b2a0f19fe Fix #121193
8894f893da6 Add platform override to default system shell
05bd596a618 Move new service to sandbox
6e84c224f44 allow for markdown dialogs and custom icons
77f067f0652 Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
d531f3b0547 Merge branch 'notebook/dev' into main
3d434efcc01 Progress on single file scenarios
b7d0ff397d3 always fire ptyReconnect after relaunch
de1c13e539c mostly working
662ea12128d NotebookCellRange is now NotebookRange.
df1214ddee9 Rename and move combined service
ebb0a7165bc update integration test.
25ea3341e0b Guess synthetic profile icon
dbbf3325212 Simplify service context by moving into browser
40ed9160e1c Implement browser profile resolver
2459b4fab9d :lipstick:
4edba25ca9c Central service for notebooks and custom editors (#120426)
d9a371b9fd4 update comments.
ae5aeabcd7d flatten custom* metadata.
271189bbabe isReadOnly contributed by the file service.
a3b1c9550dd remove cellEditable.
060d4175057 remove editable and breakpointMargin.
bcecbeb2ad9 change to async
cba995310b3 Merge branch 'main' into lszomoru/workspace-trust-loose-file
dd4350388f2 adopt to workspace trust storage service - create the service during initialization @lszomoru FYI
0688b5a7bd5 Revert "custom dialog for introducing workspace trust (#121326)"
35dcde89ee3 Revert "adopt custom and shield icon for trusted workspaces"
43295fde7a6 Remove statusMessage from constructor
fb4b3e82ed8 Adopt shell env service in TerminalProcessManager
00ae987ad04 Remove getDefaultShellAndArgs
c780db5fe26 Use new service to resolve local process paths
348a8fa1fe7 Partially implement resolve shell launch config
2436eeee72d adopt custom and shield icon for trusted workspaces
6590d3e0f78 custom dialog for introducing workspace trust (#121326)
3bb83e95562 Skip failing tests temporarily
8cf96ed6454 pass icon directly
bbf148b0c60 merge renderer IPC into notebook controller, remove global renderer IPC
337e14744c0 implement decorationsProvider
296c417c07f Add workspace trust property to auth extensions
3f4e9a0ebdf node-debug@1.44.25
150af9a47a7 Use workspace trust signal when adding a folder to a workspace (#121197)
de246aa544e Turn on showTabs by default in Insiders
a49404e6443 Resolve todos in profile resolver
68d9e023384 add support for isPreferred for notebook controllers
b2103c79e45 add preloads to notebook controller, fyi @connor4312 NotebookKernel will go out soon
16663d23bc1 Register the new service
e5ab815d0c3 Fix collapse all tree view focus Fixes #120990
151c7d5dff0 Recognise commonly sourced files as shellscript (#121373)
9a0441e9cb8 Inject last active workspace
c079d216f0e actually remove fileName from the notebook document implementation, https://github.com/microsoft/vscode/issues/121329
45097cfcc9e remove NotebookDocument.fileName, https://github.com/microsoft/vscode/issues/121329
b6cee1ca22f add cancellation to NotebookSerializer, https://github.com/microsoft/vscode/issues/121329
afa4a2df2c3 rename to serializeNotebook and deserializeNotebook, https://github.com/microsoft/vscode/issues/121329
0287003973e workspace is virtual if all folders are virtual
b27d796dfc1 Inject context, convert functions to async
255f82dbece editors - move some code out of common/editor.ts
495ad394f46 Fix layering issues
8681ecba619 editors - move some code over to browser/editor.ts
fdca487fd41 Implement resolving default/synthetic profile
679c373828e editors - remove whenClosed from editor service and make a standalone helper specific for text files
12c93777db4 Merge branch 'main' into lszomoru/workspace-trust-loose-file
d13686a8607 Extract isWorkspaceTrustEnabled into a function (#121385)
9f4eceb52cb Merge remote-tracking branch 'origin/main' into tyriar/shell_resolve_refactor
91f8c81acbc Reveal active terminal on change
e24c03de151 Center +v when collapsed
520462074de working copies - first cut typeId support
6f9917d81fb no more need to dispose ExtHostCell
f8cf56ae9e7 Merge pull request #121272 from akosyakov/akosyakov/remote-race-between-terminal-121270
f1d0c30f1e0 pass cells and controller to execute handler
0aabafd35f9 NotebookControllerOptions instead of NotebookKernelOptions
f5bfd64982b Merge branch 'main' into notebook/dev
57b8d811da1 print cycle of dependencies when instantiation service alerts for loop, fyi @lszomoru
220560dd404 Switched to using Restored instead of Eventually for the extension enablement soft notification
c91c21bab07 Tweak dialog based on feedback
a4d95b35c4e Merge branch 'main' into lszomoru/workspace-trust-loose-file
f9ca74adc43 Merge branch 'main' into notebook/dev
e51173f3b6f startup code :lipstick:
92d5997b1df "Help us improve.." notification is displaying language IDs (fix #121216)
25785b97e53 Adopt `requireTrust` for my configs
e870a6d7004 Update js/ts grammar
a5d656cd3f7 Configure workspace trust for simple browser and image preview
293061802c2 Add workspace trust for markdown extension
be2026c324c Only try to scroll to element when the target path exactly matches the base path of the current page
2ea7c77bf88 Remove statusMessage metadata
edbdd6fe092 Fix test, fix cell data startTime and duration visibility
0a6309be1ee Support markdown styling in task descriptions. (#121338)
2881355f372 Use es2020 as the default target for js/ts implicit projects
3e5c20b7626 Change execution duration to startTime/endTime
fe7f4c0241e Do not run code actions on auto save
bec017d389c testing: rework discovery side of testing to new apis
063bc4b7b11 Support seeding selected search text from embedded editors Fix #121060
1329659d841 Remove "please" from messages Fix #121312
7f2bcc15304 Fixes #119032 - changes to support settings UI
88361f24e07 DAP: add a missing comment
f065ba8d8a4 DAP: pass launch config to restart request
81fb5b7accf Merge pull request #121328 from microsoft/sandy081/settingsEditor/trust
263b76c8f00 add colors to css
e660d60f84c Merge branch 'main' into merogge/terminal-status
2ed7f15346f adjust opacity
bce7ea241ec incorporate UX feedback
7a72e4e95be fix styling in wt badge
36fcc538bda Merge branch 'notebook/dev' into main
6d468a59f69 Fixes #121325 - fixes notification deduplication
a9c869d4208 add statusIcons to terminalTabsWidget labels
dfc8f1fd037 Move back to min-width for hover hr
9a2b9a79f4a Add a very basic hover for the terminal tabs
22dd9030841 terminal: fix swapped cols/rows
d27fa1df47e #118077 introduce delay option
c4f59fa1e01 only show workspace scoped configurations
54beeaada6c Remove TerminalTabs from tabs, polish selection/focus
b7157be21e6 Fix compile
3e40e14bc41 Cell statusbar API (#121215)
93754ff5f0f Fix terminal tab actions to work on the hovered instance
ab15aa4d393 fix build error
a32d03dad99 modal false by default
040cfa078b1 Add override in notebook code
5b4ee563a1d Add override modifiers in a few more places
6299e56d22f debug: start debugging requires trust
f590a4901c0 add statusIcons to terminalTabsWidget labels
4e6b46a15f3 Implement notebook selection status bar item Fix #121194
279bdca34a2 Set title when reused terminal slc has name
6d81daa07c0 fix #121140.
3636a058e58 Fix launching profile from PATH var
08f9bbc2394 typo
fa56f6ea3db Add telemetry for import statement completions (#121243)
b42484b6871 add status icons and listeners
9c0300872ed simpler storing of ExtHostNotebookEditor
9afc7348000 no nested DOM.schedule.
361ba1a8231 update scrolling.
d3394d21773 set maxheight and overflow hidden for output container.
02f0f4a0c8e make createNotebookRendererCommunication independent of controller, make it renderer first
304200343eb Comment out unused prop
071b4b3b872 Add override to tasks and tunnels Part of #120675
1351e8c6e40 Add padding to terminal plus button
5c74225ab18 Workspace trust transition improvements (#121173)
4cf3e89b67f Fix tab widget layout height
af1b5066622 Merge pull request #121291 from microsoft/sandy081/activitybar/hover
388d40ffc3a Disable escape sequence logging by default
94f637a4965 Add new terminal with profile button
ec579a2c217 Mark server ready extension trusted
6c2ccf8be54 Implement custom hover for activity bar and panel
b2d002de4bb Fix centering, use action bar for +
fd640b0b32a Fix tunnel privacy context
20784c13a10 fixes #120981
85bf18a6d8d Correctly align plus button on load
ab0809ce864 Clean up terminal tabs widget ctor
0ea92219740 Improve plus icon position, style
c9b2c542316 rename NotebookKernel2 to NotebookController
d6ae97cf976 add Kernel2#createNotebookRendererCommunication
cb8b3ce97b6 polish remote menu separators
5371ac58c40 Include virtual workspace check for task type enablment
38066c2802c node-debug@1.44.24
7dd3678adf7 Change action order in tunnel view order in tunnel view
f15bbef705d Do some magic to pick best label action for ports Part of microsoft/vscode-remote-release#4826
94d369e27d1 backups - explicitly wait for editor group to signal restored when deciding to drop backups or not on shutdown
d9008be9ab5 Empty workspace is untrusted
5b66335738f perf - change lifecycle phase restored to work differently
4453232aee6 fix #121270: race between terminal create and initial resize
3d276ed5cc7 vscode API - env. Fixes #121261
907ab317dee fixes #120637
3ba684ae3aa Fix styling issue in the workspace trust editor
e7934ec243a Moved telemetry into a contribution
1317cdbc5dc remote: unnecessary separator
f157a3d2019 Merge branch 'main' into notebook/dev
02f2f886985 fixes #121248
f9490e715c4 fixes #121162
bb19564a844 fixes #121156
c2c5b7eaeb9 fixes #121117
7968e137fe3 fixes #120840
4ea838bcce9 perf - fix issues with how layout restore is handled
08226f4678c editors - whenCreated => whenReady
a09d6403113 github auth: improve test env detection
b5dfdbe00f1 editors - some :lipstick: renames for editor group model
b7b1315457f prefix terminal CSS rules (#121258)
730d57ed65e fix #120485 hide `Open Timeline` from Explorer context menu when there are no timeline providers
c8d5c905bfd Fixes git rename on windows
a11959e28cc Fix tests
66d0f975442 replace vars to fix build in terminalActions
44b3df962fb more todos
485d6c36463 Fix double localization
509c20c9b13 some API todos.
f59a77842e6 Use markdown for link contributions. Ref #120050
7a2f9014556 Only await for worker ready when setting content
1d22f863622 Don't wait until getting content to register service worker
a9216fb38c0 Remove __leftMargin__
c188a51edef Use clientHeight instead of computing the size ourselves
4ffd6a8d742 Merge pull request #120878 from microsoft/merogge/tabs-button
066dae222ff Merge remote-tracking branch 'origin/main' into merogge/tabs-button
72b09f10193 Compensate for out of sync clocks in cell timer Fix #117460
084668c6270 remove workspace trust grant/deny actions from gear
e143ce4a8c1 remove confusing elements from workspace trust editor
776ab3d6e5e Only enable pointer events for the folding indicator itself
5276ebf9509 Make sure we focus the markdown cell on contextmenu
3bf5b37fcfc Don't trigger notebook.find when focus is in another editor Partial fix for #121242
7f805ea0d93 Simplify redundant context keys
9cd8ff410e5 🧹
294e3eb7ef7 make private readonly in constructor
388a0c80dfd change type of icon to string | undefined
6e5a0a58032 Update src/vs/workbench/contrib/terminal/browser/media/terminal.css
3357bf274be fix hideText
d13a914bd6f Merge branch 'notebook/dev' into main
4dfa06cd356 snap right or left based on midpt
c5fab4faa37 Boolean Trust State (#121141)
75f2ce9735c Adopt workspaceTrust
40a6563f9b0 Remove git-ui extension
51451d8355f get rid of unused menu
a0099970e94 align button
71230441fa4 get button to stay on the page
090554355df notebook: cache preferred mimetypes for renderers
abf4835fd28 use tab instead of terminals
ab650745458 add instance connectors
a3444b12123 Theming for keybinding label (#120727)
9d1bfa6a6aa update distro
1d5f53777cd finalize #77423 (#121213)
23e346ab55a Add allowCommands option (#121211)
c826e9aabd2 Explicit remote CLI commands (#121212)
b3ff207039a get text to show or hide appropriately
ceda963326c Change proxy scope based on `useHostProxy` flag (#121207)
2e165500a6d Use CSS variables (#121208)
71043537525 php: use which (#121210)
f0a344a76e2 npm: use which (#121209)
bacfb76d909 localize action names
cb6a3cc3775 add rename  Co-Authored-By: Daniel Imms <daimms@microsoft.com>
80dba2b8782 set min width  Co-Authored-By: Daniel Imms <daimms@microsoft.com>
75bce498f9e fix css
ed139c10361 hide label text when min view Co-Authored-By: Daniel Imms <daimms@microsoft.com>
e0a85f94c59 Move windows mitigation comment into terminal process
fa852ac3f16 Remove redundant call
36c68a5d6dd Speculative fix for unresponsive pty host
83f13c70ff5 Merge pull request #121181 from microsoft/tyriar/reconnect_fix
f2b1e94fe78 api todos update
7c946e118a6 add onDidChangeNotebookAssociation-API and wire everything up using the glue adapter
dd14addcbd1 adopt to trusted configurations
fc15ccef8d5 Fix terminal reconnect, remove writeSync completely
ade32e71e59 add abil…
@JacksonKearl
Copy link
Contributor

Re using status bar progress for low priority notifications, I've been using that to show the download of the search index in remote hub and I've gotten feedback from a few different people (@kieferrm , @lszomoru , maybe others) that they did not see it at all. I think there's a general concern that people aren't going to look down to the status bar for progress notifications while they are focused on elements elsewhere in the editor.

@isidorn
Copy link
Contributor Author

isidorn commented May 5, 2021

@JacksonKearl yeah I think that's the point, if they are low priority it is fine if some users do not notice it.
Things like download progress of the search index sounds to me like a perfect candidate for the status bar. Unless it was triggered by the explicit user action in the search view, than on top of this showing a progress spin in the search view makes sense. Though you understand this flow better than me so feel free to ping me and we can connect on this in a short meeting.

@miguelsolorio
Copy link
Contributor

I've pushed changes to the vscode website and added the decision tree from above. If anyone has any additional changes/feedback, please add them here. Thanks!

@isidorn
Copy link
Contributor Author

isidorn commented May 26, 2021

@misolori thanks for updating the guidelines 👏
@devinvalenciano can we now share these guidelines with some of our partner extensions?

@yunusefendi52
Copy link

yunusefendi52 commented Jun 15, 2021

I just updated vscode to latest version, the formatter dialog now prevents me from typing because now it's blocking me, from the diagram above which desicion is this taken from? In my opinion the formatter dialog should not be blocking, I know it's user triggered but at the same time it's triggered while typing which should not be blocked and there is no need for immediate action

Note: Previous version if there is no formatter, it's showing notification prompt instead of dialog (which IMO is the correct one)

@alexr00 alexr00 removed their assignment Jun 18, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Jun 22, 2021

We are not blindly following the diagram, it is just a recommendation on the best flow.
As for the formatter if you think this interrupts the flow please file a new issue with repro steps and ping me on it @isidorn and we can discuss it further. Thanks

@isidorn
Copy link
Contributor Author

isidorn commented Oct 18, 2021

No further action items planned here, thus closing for now.

@isidorn isidorn closed this as completed Oct 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests