Formatter should show notification modal instead of blocking dialog if there are no formatters installed

[yunusefendi52]

In previous version (1.55.2) if there are no formatters installed it shows notification modal instead of blocking dialog, but the latest version (1.60.0-insider) it shows dialog. The reason I am not a fan of dialog in this case is because it prevents from typing and I have to close the dialog before continue typing, here is examples from v1.55.2 and the latest version (1.60.0-insider)

vscode v1.55.2 shows notification modal

vscode v1.60.0-insider shows dialog, which prevents from typing

context: #119463 (comment) and related issue #119463

cc @isidorn

[isidorn]

@yunusefendi52 this is fair feedback and thanks for the nice gifs.
However the previous experience was not nice either: the notification was always popping out.
I hope that in the new experience you press cancel once and the dialog no longer appears ever?

I would suggest to keep this open for now and if we get more feedback before reacting.

fyi @jrieken

[yunusefendi52]

I hope that in the new experience you press cancel once and the dialog no longer appears ever?

I think cancel should be meant only for cancelling the dialog and not having other side effects
but if I can pick both, I would have pick both but with some sort of settings to decide which one should be showed (notification or dialog), I am not sure if that's going to clutter the settings page though

[isidorn]

We will definitely not add a setting to control if there is a modal dialog or a notification. We should figure out what is the better experience and stick with it. Currently we are leaning towards modal dialogs.