Extensions use notifications too much to notify the user to reload

[isidorn]

Refs: #119463

I noticed that in the extensions land we often use the notifications to let the user know that he needs to reload in order for the extension to be fully instaled / uninstalled, while in some cases I guess that makes sense overall I think:

• We shuold not do this when the user uninstalled an extensions
• Here since the user was already asked via a model dialog. So if he says yes, we should automtatically install and reload, and not ask again via a notification

[sandy081]

I think the problem here is that install is a long running operation and reload can happen after a moment when user might be doing something. This might be annoying if we just reload then?

[isidorn]

If it was user initiated I think it makes sense to experiment with automatic reloading (if extension requires it).
Maybe we could do this change start of a milestone on insiders so we get a feeling for how it would behave. If we do not try we will not know if it will be annoying :)
Of course the button would need to be updated from something like "Install" to "Install and Reload"

Also reload is pretty fast so that is why I am optimistic in this flow.

[sandy081]

Fine with me. But cc-ing @joaomoreno as he is the primary owner for url handling

[joaomoreno]

No sure what this has to do with url handling? This prompt is necessary because it is destructive.

[isidorn]

I created this issue more to tackle many cases where we install extensions and offer a notification for the reload.

My idea was if the extension install is user triggered could we compress this into one action "Install + Reload", mostly in that time period between the two there is nothing that the user can do that can be destructed.

But in general I like our update flow. Update gets installed, badge in gear -> reload to update.
Why can't we have a similar flow for extensions. Extensions gets installed, badge in extension viewlet -> some action in there to reload.

[sandy081]

Can we be specific here about what issue we are discussing? Are we talking about general extension installation or this specific case where user tries to open an URL that is handled by an extension that is not installed?

In general extension installation, we do not show reload because we enable the extension automatically.

In this case (extension url handling) - URL handler installs the extension and it is up to it to reload or not or handle the url immediately.

My recommendation would be not to generalize this problem and go case by case as every feature requiring installing extension has its own requirements. So in this case, I would request @joaomoreno to decide what he would like to do after installing the extension.

BTW I am all in for showing a badge in the extensions view for those extensions requiring reload - I already have this feature request. But is this going to fix and improve this scenario ?

[isidorn]

@sandy081 going case by case makes sense, sorry for not making this more explicit. So here's the list of usages where we offer to reload:

• VSIX commented by @sandy081 - this is to inform that installing a vsix is completed. Reload is only needed if user tries to install the same extension again. So I would prefer to retain this info prompt and show reload badge if needed.
• Reinstall commented by @sandy081 - I think notification can be removed as we show installed extensions view already that shows reload badge
• Install when reload required commented by @sandy081 - I think notification can be removed as we show installed extensions view already that shows reload badge
• Malicious Extension commented by @sandy081 - This is VS Code automatically uninstalling an extension as it is malicious, so the prompt makes sense here.
• URI Handling @joaomoreno please comment
• Extensions Disabled @lszomoru please comment
• Cached Extension Scanner
• Example where we already do install and reload in one go

My point is that looking at the code we seem to be doing this a lot and introducing a general approach to this problem might help.
@sandy081 you of course know each usage much better than me, I have simply glanced at this and I do think that the Extensions badge can improve a lot of these scenarios. Or one install + reload button.

[sandy081]

@isidorn I updated my comments in the above list and asked @joaomoreno @lszomoru for their comments in their scenarios

[isidorn]

@sandy081 great, thanks a lot!
Can we maybe assign this to May or June so we do not loose track of this?

[joaomoreno]

I think keeping the URL handling notification makes sense.

[vscodenpa]

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!