Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Do you want to install the recommend extensions for this repository" should not show up on startup #121802

Closed
isidorn opened this issue Apr 21, 2021 · 18 comments
Assignees
Labels
extension-recommendations Extension recommendations issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 21, 2021

Refs: #119463

Open the vscode repo using a new user data dir. Notice you get 3 notifications directly in your face.

I suggest the following:

  • Add an entry to the welcome page / getting started view to install all recommended extensions for this repository
  • Only show the "Do you want to install the recommended..." once a user opens a Code editor for the very first time

fyi @JacksonKearl for welcome view
@chrisdias for pm thoughts

Screenshot 2021-04-21 at 11 21 36

@isidorn
Copy link
Contributor Author

isidorn commented Apr 21, 2021

Related usage https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/extensions/browser/extensionRecommendationNotificationService.ts#L167

Don't we have a don't show again button under the gear. Why is there a custom solution to use notification prompts to not show this again?

@JacksonKearl
Copy link
Contributor

Lots of folks don't have welcome views enabled at all, so only placing it there seems insufficient. Could it be a badge on the extensions activity bar item?

@isidorn
Copy link
Contributor Author

isidorn commented Apr 21, 2021

@JacksonKearl yup. But good idea, I think we need a combination of a couple of things.
So an extensions badge approach I really like

@sandy081
Copy link
Member

Underlying problem is that we are lacking a better way to recommend extensions.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 22, 2021

I am not saying we have to change the approach but the timing at least. From above:

Only show the "Do you want to install the recommended..." once a user opens a Code editor for the very first time

Or if you have a better idea for when.

Or we could think about this in the UX meeting how to show a badge in the activity bar for the extensions viewlet if you like that idea...

@sandy081
Copy link
Member

Only show the "Do you want to install the recommended..." once a user opens a Code editor for the very first time

Sorry I missed this comment. Yeah I liked this idea and I also feel annoying seeing this every time I reload. But since recommendations are owned by PMs I would also take their opinion.

Or we could think about this in the UX meeting how to show a badge in the activity bar for the extensions viewlet if you like that idea...

Sure, but hope this does not goes into over all recommendations UX discussion 😄

@isidorn
Copy link
Contributor Author

isidorn commented Apr 22, 2021

@sandy081 great, then maybe let's start small and only improve when this is shown. Not on startup would be great!
Some ideas when we could do it:

  • After some timeout. For example 10 minutes
  • When first code editor is open
  • Only when the user has no other notifications (so we do not show 3+ notifications like in my example)

@devinvalenciano can you be our PM support here. Can you please talk to the PM team and see if there are big objections if we change when we show workspace recommendations. Please keep in mind that this is only for workspace recommendations. We would not change the flow of you open a .py file and a python recommendation is shown.

@devinvalenciano
Copy link
Contributor

Whatever path we take, I'd be interested in running this as an A/B experiment - that way we can determine whether the changes are beneficial to the user experience. I'll get this issue in front of the PMs now.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 26, 2021

@devinvalenciano makes sense, we can run an experiment. However let's first be creative and try to figure out what is the best timing to show the notification. Or if we want go do down the badge in extensions viewlet approach

@bamurtaugh
Copy link
Member

I agree 3 notifications is overwhelming. Users may not click any notifications if they see too many, or they may click to install extensions since that sounds more familiar/important to them than reopening in a container. But if they do want to work in a dev container, that should be the first experience they click into (and those locally installed extensions won't serve them as effectively for this project).

Thus, I'm inclined to think showing extension info 5-10 mins after startup (user has done some work, already decided if they're working locally or in a container) and/or if there are no other notifications makes sense.

@sana-ajani
Copy link
Contributor

@digitarald @JacksonKearl also, similar to how some of the intermediate content is shown in Getting Started, could the "Limitless extensibility" entry be amended to show the workspace recommended extensions when the user is viewing Getting Started and has a folder open?

@digitarald
Copy link
Contributor

I share @JacksonKearl's doubts that Getting Started is the right avenue. It is meant for the first-time user scenario, whereas Workspace recommendations are meant for first-time opening of a specific workspace.

I assume we could check how many notifications users see within the first seconds of using VS Code and if this triplet is representative?

Only show the "Do you want to install the recommended..." once a user opens a Code editor for the very first time

That would work. It moves it off the initial notification storm, as installing extensions will trigger another burst of welcome pages and notifications (until we get those tamed).

Alternatively I had an older UX proposal that moved the notification to a hint on the extension activity bar icon and expanded the existing recommendation section in the extension viewlet. This could combine the various extension recommendations that VS Code does; but potentially lower the rate of users installing the important extensions.

image

@bamurtaugh
Copy link
Member

Alternatively I had an older UX proposal that moved the notification to a hint on the extension activity bar icon and expanded the existing recommendation section in the extension viewlet.

This reminds me of the badge model we were discussing in #121805 (comment). If we shift user thinking to this badge model for a few different flows, they may still be inclined to explore it since they know badge recommendations are useful, but they won't be immediately overwhelmed by multiple notifications.

@sandy081 sandy081 assigned isidorn and unassigned sandy081 Oct 6, 2021
@sandy081 sandy081 added extension-recommendations Extension recommendations issues under-discussion Issue is under discussion for relevance, priority, approach labels Oct 6, 2021
@sandy081
Copy link
Member

sandy081 commented Oct 6, 2021

@isidorn Assigning this to you for PM discussion and conclusion.

@isidorn
Copy link
Contributor Author

isidorn commented Oct 7, 2021

Conclusion: can we show this notification not on startup but only when the user opens a code editor (not welcome page).
If a code editor is already open on startup then show it on startup.

@sandy081
Copy link
Member

Yes we can trigger this only when this editor (code) is opened

@isidorn
Copy link
Contributor Author

isidorn commented Oct 11, 2021

Ok, then let's give that a spin once we find time.
Also assigning to you.

@sandy081 sandy081 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 11, 2021
@sandy081 sandy081 added this to the Backlog milestone Oct 11, 2021
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-recommendations Extension recommendations issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

8 participants
@digitarald @devinvalenciano @isidorn @JacksonKearl @sana-ajani @sandy081 @bamurtaugh and others