Can not save because the settings file is dirty

[isidorn]

Could we simply automatically save the file in this case and no need to show a notification?
Code pointer https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/workspaces/browser/abstractWorkspaceEditingService.ts#L300

That would make this a much smoother experience

Refs: #119463

[isidorn]

Same use case here https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/configuration/common/configurationEditingService.ts#L259

Could we automatically save those configuration files so we do not get "file is dirty" errors

[connor4312]

Are there steps for this? I tried making a conflicting dirty settings files, but I don't think this is what you were talking about...

[sandy081]

To verify

• Disable autosave
• Open settings.json file and make it dirty
• Open settings UI and change some settings
• Make sure setting is applied and file is saved.

[karthiknadig]

Thanks for the steps @sandy081 that worked.