KeymapExtensions handling still needed?

[isidorn]

Refs: #119463

I noticed that there we are having some special code for checking conflicts in keymap extnesions https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/extensions/common/extensionsUtils.ts#L26

I believe this is no longer needed and we could just do the following:
WHen a user installs a keymap extension that we show a modal dialog that he already has one installed and if he is sure what is he doing and offer to disable the other one. If he says yes, we proceed.

I think that would be a clenaer solution than having an Keymap workbench contribution which handles an obscure case of users having multiple keymap extensions.

Not sure who is the owner, based on blame assigning to @chrmarti and @sandy081

[chrmarti]

Moving the user interaction closer to the user's decision to install a second keymap extension makes sense. Not sure if that will cover all cases (like when installing all in extensions.json), but it might be just enough because it covers the most important case.

@sandy081 Is this something you could implement? (Removing the current code should not be much work.)

[sandy081]

I agree that moving the decision closer to user interaction is good and makes sense. But I feel that existing check is still needed as extensions can come in from multiple other sources

[isidorn]

Yes, but that is a corner case. Two keymap extensions coming from the other source. In reality how many times do you think that happened?
I think this was much more important while VS Code was an up and coming product. Now we are established and keymap extensions are not as important as they were before since we dictate the keybindings.

Due to the above I suggest to simply remove this in insiders and if 1 user complains feel free to take it back. I think that nobody will even notice it.
Of course having the check after installing would be nice.

[vscodenpa]

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!