-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSDoc @link tags #119357
Comments
Fixes microsoft#119357 Fixes microsoft#89966 In order to implement this, I also added API that lets markdown strings allow just a subset of command uris. This is required because we have to use a command to implement the links, but do not want to allow just any command to be run
Fixes microsoft#119357 Fixes microsoft#89966 In order to implement this, I also added API that lets markdown strings allow just a subset of command uris. This is required because we have to use a command to implement the links, but do not want to allow just any command to be run
Fixes microsoft#119357 Fixes microsoft#89966 In order to implement this, I also added API that lets markdown strings allow just a subset of command uris. This is required because we have to use a command to implement the links, but do not want to allow just any command to be run
Fixes microsoft#119357 Fixes microsoft#89966 In order to implement this, I also added API that lets markdown strings allow just a subset of command uris. This is required because we have to use a command to implement the links, but do not want to allow just any command to be run
For verification:
|
Using TS 4.3.0-dev.202104017 and adding adding links in vscode.proposed.d.ts but I don't get this to work... Only http-links seem to work, this is my sample /**
* An array of language identifiers that are supported by this
* controller. Any language identifier from {@link NotebookController} [`getLanguages`](#languages.getLanguages)
* is possible. When falsy all languages are supported.
*
* {@link http://www.sne.ch }
* {@link viewType }
* {@link vscode.notebook }
*
* Samples:
* ```js
* // support JavaScript and TypeScript
* myController.supportedLanguages = ['javascript', 'typescript']
*
* // support all languages
* myController.supportedLanguages = undefined; // falsy
* myController.supportedLanguages = []; // falsy
* ```
*/
supportedLanguages?: string[]; |
Thanks @jrieken. This is a TS bug: microsoft/TypeScript#43868 Let me know if you come across any other cases that do not work with this feature. To verify basic class Foo {
/** {@link Foo} */
bar(): void {}
} |
Super cool, found one annoying bug but this'll make life a lot easier. |
Tracks the VS Code side of microsoft/TypeScript#35524
This would include supporting
{@link}
tags in hovers, completions, and quick infoThe text was updated successfully, but these errors were encountered: