Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Getting Started] Task action for installing extensions #119502

Closed
digitarald opened this issue Mar 22, 2021 · 9 comments
Closed

[Getting Started] Task action for installing extensions #119502

digitarald opened this issue Mar 22, 2021 · 9 comments
Assignees
Labels
api feature-request Request for new features or functionality getting-started verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@digitarald
Copy link
Contributor

Getting started can help to set users up with the right extensions early on, making them more contextual and reducing prompts.

As the current command-driven actions don't work for installing extensions, having an action for installing specific extension that also triggers the done state would solve this.

@digitarald
Copy link
Contributor Author

digitarald commented Apr 20, 2021

This was also brought up from @jureid for the C++ walkthrough, recommending CMake/Makefile for when those configurations are detected. A good point was that this action should check if the extension is installed, so it doesn't show for users who already got the extension.

@JacksonKearl
Copy link
Contributor

cc @sandy081 is there any command currently for installing extensions? Would you be opposed to adding something like that? I ask because we could either implement this via adding an installExtension(id) command and using the existing [Install Foo](command:installExtension?foo) style contributions, or add some new syntax like [Install Foo](installExtension:foo)

@JacksonKearl JacksonKearl modified the milestones: April 2021, May 2021 Apr 28, 2021
@sandy081
Copy link
Member

Yes there is a command to install an extension passing extension id - workbench.extensions.installExtension. But this will ask for user consent to sync or not if settings sync is enabled.

@JacksonKearl
Copy link
Contributor

Neat thanks! Asking user for sync consent is fine. Cc @digitarald would this work for the C/C++ folks?

@digitarald
Copy link
Contributor Author

As the action on the button, yes 👍. To avoid confusion VS Code needs to support some doneOn clause that checks the step off when the extension is already installed.

@JacksonKearl
Copy link
Contributor

Tracking improving doneOn in #122570.

The act of installing is possible today with [Install The Thing](command:workbench.extensions.installExtension?%22extension.id%22).

@JacksonKearl JacksonKearl modified the milestones: May 2021, April 2021 Apr 28, 2021
@JacksonKearl JacksonKearl added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Apr 28, 2021
@sbatten sbatten added the verified Verification succeeded label Apr 28, 2021
@sbatten
Copy link
Member

sbatten commented Apr 28, 2021

I'm not sure what the scope of verification includes for this. Yes, you can create a button that installs an extension, but it happens silently behind the scenes and feels like nothing happened. Maybe when the task automatically checks off the task it will feel better, but even then, there is no progress shown so larger extensions will feel broken for a few seconds.

I think having a way to show progress, either through progress notifications or directly in the step widget would improve this.

@JacksonKearl
Copy link
Contributor

@sandy081 would you consider it in-scope for the workbench.extensions.installExtension to show a progress notification? Otherwise I can create my own command for getting started that calls out to that one but shows progress as well.

@digitarald
Copy link
Contributor Author

happens silently behind the scenes and feels like nothing happened

I see the same issue for extension recommendation installations in usertesting. Without the extension viewlet visible, the progress context is completely missing. A progress notifications seems useful, especially on slower connections.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality getting-started verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants