-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermediate content for Getting Started #120602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few optional wording suggestions, but looks good!
Hot take: can we add "LiveShare" as an entry in this intermediate list? I know it's not really a productivity tip, but I really think a) it's one of the more life-changing, sticky features/extensions of VS Code that users should know exists especially now in remote times and b) it could be a "first-class" extension in the editor, because its language agnostic.
I might suggest swapping it with tasks or hotkeys, because I think more people will actually be able to use it. (So not sure if it belongs in the intermediate section... or in the fundamentals perhaps?)
Title: "Collaborate and code remotely"
Description: Edit and debug your code in real-time. Invite your friends and colleagues to join your coding session.
Button: Open extension view with id:@"ms-vsliveshare.vsliveshare-pack"
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedContent.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedContent.ts
Show resolved
Hide resolved
{ | ||
id: 'playground', | ||
title: localize('gettingStarted.playground.title', "Redefine your editing skills"), | ||
description: localize('gettingStarted.playground.description', "Want to code faster and smarter? Practice powerful code editing feature without creating files or a project."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like framing this as practicing without creating a project, but I also think of the tips in interactive playground as life hacks. Perhaps: "Want to code faster and smarter? Practice these must-know editing hacks in the playground."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Life hacks makes some sense, but hacks doesn't seem the right for multi-cursor. Lets try this out as less formal version during the content experiment!
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedContent.ts
Outdated
Show resolved
Hide resolved
title: localize('gettingStarted.playground.title', "Redefine your editing skills"), | ||
description: localize('gettingStarted.playground.description', "Want to code faster and smarter? Practice powerful code editing feature without creating files or a project."), | ||
button: { | ||
title: localize('gettingStarted.playground.button', "Interactive Playground"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To stay consistent with button labels starting with a verb, should this be "Open Interactive Playground" or "Open Playground"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was concerned about space, as we have a few buttons that have line-breaks. This one seems fine though.
{ | ||
id: 'scmClone', | ||
title: localize('gettingStarted.scm.title', "Track your code with Git"), | ||
description: localize('gettingStarted.scmSetup.description', "Set up your project to use Git and GitHub integration right inside your editor."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"right inside your editor" seems awkward, since they are already inside the editor. Maybe, "set up your project to use Git and GitHub with a click of a button?" to show how easy it is from VS Code?
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedContent.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedContent.ts
Outdated
Show resolved
Hide resolved
@sana-ajani 🤩.
Yes, was on my list, aiting on #119502. Also a WSL mention for windows users. |
1fec6ee
to
8640876
Compare
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedContent.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/welcome/gettingStarted/common/gettingStartedContent.ts
Outdated
Show resolved
Hide resolved
{ | ||
id: 'shortcuts', | ||
title: localize('gettingStarted.shortcuts.title', "Customize your shortcuts"), | ||
description: localize('gettingStarted.shortcuts.description', "Once you discovered your favorite commands, lookup and customize their keyboard shortcuts for instant access."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
"Once you have discovered your favorite commands, create custom keyboard shortcuts for instant access."
This PR fixes #118281.
Git has 3 different tasks that trigger based on a) no folder open (clone), b) folder without git open (init repo) and c) open scm view (folder with git open).
Screen recording of the flow and in which contexts tasks appear:
intermediate.mp4
Skipped on high-contrast images for now to save bytes as we try this out in Insiders, gather feedback and tweak content.