Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of variable breakpoint not clear in Breakpoints view #119588

Closed
alexr00 opened this issue Mar 23, 2021 · 4 comments
Closed

Type of variable breakpoint not clear in Breakpoints view #119588

alexr00 opened this issue Mar 23, 2021 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Mar 23, 2021

Testing #119197

I can see no way to tell that one of my variable breakpoints is for "Read" and the other is for "Access"

image

Also, if I right click on one of these breakpoints and choose "Edit Condition" nothing happens.

@isidorn
Copy link
Contributor

isidorn commented Mar 23, 2021

For the edit condition we have this feature request #114903
For showing the type of access. I think we should render it. Similar in style to how breakpoints show the breakpoint path..

@yannickowow let me know if you are interested in providing a PR that would tackle this issue. If you do not have time I can also look into this. Thus for now assigning to April

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Mar 23, 2021
@isidorn isidorn added this to the April 2021 milestone Mar 23, 2021
@yannickowow
Copy link
Contributor

@isidorn I can investigate if you want.
Would it be better to see it like breakpoint paths or breakpoints line ?
And it would be a sentence like : Break On: Read or something like "R", "W", "A" ?

For the first case, here is a prototype :
image

@isidorn
Copy link
Contributor

isidorn commented Mar 24, 2021

Yeah styling exactly like that. It should be like breakpoint paths.
However I think we can just say: "Read", "Write", "Access"
"Break On" part is not needed

isidorn added a commit that referenced this issue Mar 29, 2021
Show current DataBreakpoint access type in "Breakpoints" view (#119588)
@isidorn isidorn added the verification-needed Verification of issue is requested label Mar 29, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 29, 2021

Fixed via #119817
Thanks a lot @yannickowow 👏

@isidorn isidorn closed this as completed Mar 29, 2021
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Apr 22, 2021
@alexr00 alexr00 added the verified Verification succeeded label Apr 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants