Keyboard shortcut editor.action.selectHighlights selects only first 999 matches

[coe-jeubanks]

• VSCode Version: 1.5.2
• OS Version: Windows 10

Steps to Reproduce:

1. Create a file with more than 999 examples of a text string (e.g. 2,000 lines containing "This is a line").
2. Highlight a word or phrase, and to highlight all matches, press ctrl+shift+l (or whatever editor.action.selectHighlights has been mapped to).

Only the first 999 matches will be selected. This is a problem when working with large files.

[Bill-Stewart]

Just wondering if editor.action.changeAll (default ctrl+f2) has the same behavior?

[coe-jeubanks]

Yes, editor.action.changeAll exhibits the same behavior. I realized after posting this issue that it's likely an arbitrary cutoff for performance purposes. To be my go-to text editor, however, VS Code really needs to add the ability to edit large files. I hope that's on the horizon.

[Bill-Stewart]

Or at least make it user configurable...

[coe-jeubanks]

I should note that the regular Replace function (ctrl+H) replaces as many matches as it can find in the file. In the Find dialog box, it shows "1 of 999+", and the ToolTip says "Only the first 999 results have been highlighted, but all Find operations work on the entire text". Seems to me this philosophy should be extended to editor.action.selectHighlights and editor.action.changeAll operations.

[Bill-Stewart]

Related to #7577 ?

[ToMakeSense]

Related to #496 #5887 #7201 #32522..... all kinds of 999-Issues.
this bug really exists in a long period. Hope can be fixed soon. And I also think 1 of 999+ isn't good practice, Just want to know how many cases exactly are found when I do a search(Ctrl+F).

Sublime Text 3 shows it in status bar, I think it's very useful.

[ToMakeSense]

@alexandrudima I think I have find the reazon for this bug:

1. see this issues #15778 or #7577
   Ctrl+F then Alt+Enter will work for "editor.action.selectHighlights"

2. But ctrl+shift+L does't. Look at the settings
   
   
   I think the ctrl+shift+L should bind to editor.action.selectAllMatches when editorTextFocus , that is to say: editor.action.selectHighlights is misunderstood or has bug.

[Mischala]

So, I wrote about this in #7201 but its worth mentioning here.

Line 173 of findModel.ts references a "MATCHES_LIMIT", that is a constant, set on line 70 of the same file.
This appears to be the root of the problem.
I expect the reason this limit exists is to stop "Bad Searches" like searching for "s" or whitespace from running forever and locking up the app.

[alexdima]

Duplicate of #5887