changed limitResultCount to Number.MAX_VALUE for findMatches

[Mischala]

findMatches now has a much higher limit of things it will match to.
this fixed #7201
But may cause issues in searching exceedingly large files with a "bad search"

such as searching for "s" in a 400,000 line file... with each line containing 6,000 s characters

[msard-oz]

At least some kind of notification that this limitation exists should have been added. I understand that one rarely replace over a thousand instances of the same string while coding, then again, implementing RegEx, but limiting matches to 999 is just not ok. I really hope this is going to be available in the next update.

[alexdima]

If only this would be so easy!

The limit is put in place to avoid UI stalls, freezes and crashes.

I am sorry that this is annoying, but removing the limit will lead to: stalls, freezes and crashes.

You can try locally to remove the limit, generate a 50MB file containing as and then you can search for a. VSCode will crash or freeze quite quickly with this change.

[alexdima]

The extra problem about our runtime is that in OOM situations, Electron just crashes.

In other runtimes, one would be able to figure out that there is no more memory available ... and perhaps stop doing what they're doing... i.e. break the loop that finds things