Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy As menu shouldn't have an ellipsis #120066

Closed
eamodio opened this issue Mar 29, 2021 · 3 comments
Closed

Copy As menu shouldn't have an ellipsis #120066

eamodio opened this issue Mar 29, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Mar 29, 2021

Refs #118208

I don't think the new Copy As... menu should have an ellipsis at the end. Typically, ellipsis are added to indicate a dialog or confirmation will be shown on click, not for a submenu expansion. I also don't know of any other cases where ... is used on a menu item with a submenu (in our app or any others).

@eamodio eamodio added this to the March 2021 milestone Mar 29, 2021
@miguelsolorio
Copy link
Contributor

That's actually a good point, from looking at other apps and how we use submenus, the ... only applies for a single item that requires user input.

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2021
@joaomoreno joaomoreno modified the milestones: March 2021, April 2021 Mar 29, 2021
@joaomoreno joaomoreno added the menus Menu items and widget issues label Mar 29, 2021
@joaomoreno
Copy link
Member

I don't think this is severe enough to be a candidate, so assigning to April.

@joaomoreno joaomoreno modified the milestones: April 2021, March 2021 Mar 29, 2021
@joaomoreno
Copy link
Member

After endgame discussion, this is wanted for release, merging it in!

joaomoreno added a commit that referenced this issue Mar 29, 2021
joaomoreno added a commit that referenced this issue Mar 29, 2021
@rzhao271 rzhao271 added the candidate Issue identified as probable candidate for fixing in the next release label Mar 29, 2021
@eamodio eamodio added the verified Verification succeeded label Mar 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @eamodio @rzhao271 @miguelsolorio and others