Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search editor: ghosted editor and data loss when restoring backups #122099

Closed
bpasero opened this issue Apr 24, 2021 · 0 comments · Fixed by #122100
Closed

Search editor: ghosted editor and data loss when restoring backups #122099

bpasero opened this issue Apr 24, 2021 · 0 comments · Fixed by #122100
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search-editor verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Apr 24, 2021

While #118947 is probably the full solution to this, I think there are some changes that are already possible that will make restore from backups work better for search editors.

Specifically when a (saved) search editor is dirty and restored on startup, there is a "ghost tab" appearing too:

image

Even worse, if you have any dirty search editor in a folder foo and you start VSCode from the command line with code <foo> <foo/file>, dirty search editors are entirely lost:

recording

I will put up a PR to address this.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug search-editor labels Apr 24, 2021
@bpasero bpasero added this to the April 2021 milestone Apr 24, 2021
bpasero added a commit that referenced this issue Apr 24, 2021
gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this issue Apr 26, 2021
@isidorn isidorn added the verified Verification succeeded label Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search-editor verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@bpasero @isidorn @JacksonKearl and others