Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new notebook renderers #122251

Closed
3 tasks done
mjbvz opened this issue Apr 26, 2021 · 1 comment
Closed
3 tasks done

Test new notebook renderers #122251

mjbvz opened this issue Apr 26, 2021 · 1 comment

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 26, 2021

Refs #116393

Complexity: 4

Create Issue


Background

This iteration, we polished the new, extensible markdown renderers for notebooks. This allow us to render :smile: as emoji and math formulas in a notebook's markdown. These features are both contributed by built-in extensions

To support this new functionality, we had to completely rework how markdown is rendered in notebooks. All the rendering is now done in the notebook's backlayer webview inside of in the renderer process. The rendered markdown is also displayed in the webview instead of in the workbench editor

Testing

For this item, please give another exploratory test pass to markdown support in notebooks. A few general areas to focus on:

  • Performance. Are there cases where the contents of a notebook seem to shift around?

  • UX. Does interacting with notebook cells feel normal? The markdown cells should feel like they are part of the normal editor dom

  • Math support. Try a few math formulas in the markdown and see if these cause any issues

@meganrogge
Copy link
Contributor

The math formulas and emojis look great 😄

@meganrogge meganrogge removed their assignment Apr 27, 2021
@connor4312 connor4312 removed their assignment Apr 27, 2021
@rzhao271 rzhao271 removed their assignment Apr 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants