Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shell/shellArgs over defaultProfile if specified #123159

Closed
Tyriar opened this issue May 6, 2021 · 1 comment
Closed

Use shell/shellArgs over defaultProfile if specified #123159

Tyriar opened this issue May 6, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues terminal-profiles verified Verification succeeded
Milestone
April 2021 Recove...

Comments

@Tyriar
Copy link
Member

Tyriar commented May 6, 2021

There are several reports (eg. #123069, microsoft/vscode-dev-containers#838) as a result of the new defaultProfile setting. We should swap the priority such that if either shell or shellArgs is set, that will take priority over defaultProfile. This will mitigate the issues people are seeing and we can move towards swapping the priority back in the future to phase out the deprecated settings.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-profiles labels May 6, 2021
@Tyriar Tyriar added this to the April 2021 Recovery milestone May 6, 2021
@Tyriar Tyriar mentioned this issue May 6, 2021
Closed
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label May 6, 2021
@Tyriar
Copy link
Member Author

Tyriar commented May 6, 2021

image
image

@Tyriar Tyriar mentioned this issue May 6, 2021
Closed
@Tyriar Tyriar closed this as completed in 8991a1f May 6, 2021
@Tyriar Tyriar reopened this May 6, 2021
Tyriar added a commit that referenced this issue May 6, 2021
@Tyriar
Switch priority of shell/shellArgs and defaultProfile setting
04f8af0 
Fixes #123159

We were too aggressive introducing the new default profile system as many
users (as well as dev containers, microsoft/vscode-dev-containers#838) depend
on these settings for their workflow. This also includes a change in behavior
where if shellArgs are specified, they are applied to the fallback shell
(even when shell.platform isn't specified), which aligns with past behavior.
@Tyriar Tyriar mentioned this issue May 6, 2021
Merged
Tyriar added a commit that referenced this issue May 6, 2021
@Tyriar
Switch priority of shell/shellArgs and defaultProfile setting
e95e22e 
Fixes #123159

We were too aggressive introducing the new default profile system as many
users (as well as dev containers, microsoft/vscode-dev-containers#838) depend
on these settings for their workflow. This also includes a change in behavior
where if shellArgs are specified, they are applied to the fallback shell
(even when shell.platform isn't specified), which aligns with past behavior.
This was referenced May 6, 2021
Closed
Closed
@Tyriar Tyriar closed this as completed May 12, 2021
@meganrogge meganrogge added the verified Verification succeeded label May 12, 2021
@gregvanl gregvanl mentioned this issue May 15, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues terminal-profiles verified Verification succeeded
Projects
None yet
Milestone
April 2021 Recovery 2
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge