Skip to content

Allow extensions to opt-out of reconnect in extension owned terminals #123805

@TylerLeonhardt

Description

@TylerLeonhardt

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.57.0-insider
  • OS Version: macOS

Steps to Reproduce:

  1. Install PowerShell
  2. Install PowerShell extension
  3. Open a PowerShell file (this causes the "PowerShell Integrated Console" to open which is a terminal contributed by the PowerShell extension)
  4. Close PowerShell file
  5. Reload the window

Expected: No PowerShell Integrated Console (PSIC) to be restored (since an extension contributed it)
Actual: PSIC get's restored

Extra info:

Here's what they run:

vscode.window.createTerminal({
                name: this.title,
                shellPath: this.exePath,
                shellArgs: powerShellArgs,
                hideFromUser: !this.sessionSettings.integratedConsole.showOnStartup,
                cwd: this.sessionSettings.cwd
            });

https://github.com/PowerShell/vscode-powershell/blob/master/src/process.ts#L109-L115

Metadata

Metadata

Labels

*duplicateIssue identified as a duplicate of another issue(s)apiapi-proposalfeature-requestRequest for new features or functionalityterminalGeneral terminal issues that don't fall under another labelterminal-persistenceRelating to process reconnection or process revive

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions