-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential race condition issue when installing the Python extension #124870
Comments
(Experimental duplicate detection) |
It seems to be caused because Python and Pylance extensions have a bit of a circular dependency: Python is declared as an extension pack which includes Pylance and Pylance has a dependency declared on the Python extension. If Pylance is installed and activated first before Python is activated, then VS Code raises that error above. Maybe VS Code could attempt to activate an extension only when all of its dependent extensions are installed and activated? |
To verify:
|
The fix for this may have caused a regression: microsoft/vscode-python#16614 Now it seems as though Python can't find Pylance during its activation, as Python is being activated much earlier than it used to be. |
I'll re-mark this issue as verified. Four days ago, I did manage to get the error to show up once on Stable, whereas it never appeared on Insiders. @jakebailey For the regression, if there is more that needs to be done on the VS Code side, I recommend creating a new issue. |
Does this issue occur when all extensions are disabled?: No
Hi there!
When running user studies we noticed that a lot of users when installing the Python extension for the first time saw this notification about Pylance (that is now automatically installed with the Python extension):
The Python extension seems to start activation after Pylance tries to activate, or something like that. There are some failures in the logs below which I don't completely understand. But the problem is that right now on first install, a lot of users are having to reload the window to start using IntelliSense, which isn't ideal :(
I was also able to repro this by uninstalling the Python extension, then installing it again and opening a Python file to trigger activation.
If the solution would need to go in the Python extension side, I'm happy to move this issue to our repo. Just figured I'd get some light from you on how we can solve this 😊
Log (Extension Host)
The text was updated successfully, but these errors were encountered: