Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSP root folder in workspace retains '!' error indicator after successful refresh #126842

Closed
gjsjohnmurray opened this issue Jun 21, 2021 · 10 comments · Fixed by #126843
Closed

FSP root folder in workspace retains '!' error indicator after successful refresh #126842

gjsjohnmurray opened this issue Jun 21, 2021 · 10 comments · Fixed by #126843
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
August 2021

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

  1. Use an extension that implements a FileSystemProvider for which you can alter conditions so that it may or may not resolve. For example, an FTP provider connecting over a VPN that you can disable.
  2. Have a workspace that uses the FSP.
  3. Be able to resolve the workspace folder and see its contents.
  4. Change environment state to make the target unreachable (e.g. disconnect VPN)
  5. Use the 'Refresh Explorer' button. The Explorer correctly displays the root folder with a '!' indicator and colour, plus a hover tip saying 'Unable to resolve workspace folder'
  6. Change environment state to make the target reachable again (e.g. connect VPN)
  7. Use the 'Refresh Explorer' button.

🐛 the root folder retains its error indicator, colour and tip even though the folder now resolves and expands.

I will submit a PR

VS Code version: Code - Insiders 1.58.0-insider (6afedfd, 2021-06-21T05:15:13.618Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No
gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Jun 21, 2021
@gjsjohnmurray
fix microsoft#126842 clear Explorer root folder error indicator when …
8015594 
…refresh succeeds
@gjsjohnmurray gjsjohnmurray mentioned this issue Jun 21, 2021
Merged
@gjsjohnmurray
Copy link
Contributor Author

@isidorn this is in the same area as #122004 which was assigned to you.

@isidorn
Copy link
Contributor

isidorn commented Jun 22, 2021

Thanks for the issue. However I just came back from vacation and have limited time this milestone, thus I am pushing this out to July for now.

@isidorn isidorn added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Jun 22, 2021
@isidorn isidorn added this to the July 2021 milestone Jun 22, 2021
@gjsjohnmurray
Copy link
Contributor Author

Fair enough, but I'd been hoping to continue my run of having at least one PR in every release since October 2020, and this bug has been affecting users of a couple of extensions I work on 😞

@isidorn
Copy link
Contributor

isidorn commented Jun 23, 2021

Hehe that's a good reason. If I find time I will try to tackle it this week, but no promises...

@drpicox drpicox mentioned this issue Jul 26, 2021
Closed
@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2021

Whole milestone I was on vacation -> moving to August to merge in hopefully start of next wek.

@isidorn isidorn modified the milestones: July 2021, August 2021 Jul 28, 2021
isidorn added a commit that referenced this issue Aug 2, 2021
@isidorn
Merge pull request #126843 from gjsjohnmurray/fix-126842
97faef9 
fix #126842 clear Explorer root folder error indicator when refresh succeeds
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Aug 2, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 2, 2021

Adding bug label so we verify this this milestone.
@gjsjohnmurray also once there is an insider end of this week with this change it would be great if you try it out. Thanks!

@roblourens roblourens added the author-verification-requested Issues potentially verifiable by issue author label Aug 27, 2021
@roblourens
Copy link
Member

Tried to repro this with the fs provider sample, but I'm not sure how to get the yellow text and ! to show up. Should it happen just when you throw from readDirectory?

@gjsjohnmurray
Copy link
Contributor Author

/verified with my extension, where I originally identified the issue.

@roblourens
Copy link
Member

Thanks @gjsjohnmurray

@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

fix #126842 clear Explorer root folder error indicator when refresh succeeds gjsjohnmurray/vscode
4 participants
@roblourens @isidorn @gjsjohnmurray and others