-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[themes] Dark theme uses much more colors than light theme for both JS and TS #1270
Comments
Agreed, this should be consistent (in terms of what gets coloured that is, not in terms of the specific colours). What is the reason for the param name or function name not being coloured in the light theme? Do we just not have good colours specified for the light theme? If so, could @bgashler1 suggest something? |
I agree this is a problem with consistency, and it needs to be addressed. I'll try out some colors that can make up for the missing ones in the light theme. |
fix delivered, I removed the yellow and turquise. The goal is to stay as close as possible to the original Visual Studio light and dark themes. For users that like more colors we have custom themes even from extensions. |
But turquise we still use in light theme. Maybe bring back turquise, since now interface names are colored in dark theme but not in light -> inconsistent |
I removed turquise from the light theme as well. We are now consistent to what we had in 0.9.0. |
Compare the two screenshots. We use much more colors in the dark theme. This is not consistent since those two are the default themes and they should be symetric imho. Both for Typescript and Javascript
@stevencl @bgashler1 opinions welcome
The text was updated successfully, but these errors were encountered: