Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the setting for Simple File-Dialogs #127201

Closed
igorskyflyer opened this issue Jun 25, 2021 · 4 comments
Closed

Override the setting for Simple File-Dialogs #127201

igorskyflyer opened this issue Jun 25, 2021 · 4 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@igorskyflyer
Copy link

igorskyflyer commented Jun 25, 2021

Hello, I've created an extension that uses the vscode.window.showSaveDialog function and [it] would really benefit the ability to ignore the global files.simpleDialog.enable setting and always use built-in Simple Dialogs and not use the OS/native Save Dialogs. Is it possible to override this behavior when callingvscode.window.showSaveDialog?
If not, are there any plans for such feature?

@alexr00
Copy link
Member

alexr00 commented Jun 28, 2021

The user made the choice to set files.simpleDialog.enable, so if we provided a way way for extensions to choose which file picker to show then we would be ignoring an explicit user choice. It is intentional that we stick to the user's chosen setting here!

@alexr00 alexr00 closed this as completed Jun 28, 2021
@alexr00 alexr00 added the *as-designed Described behavior is as designed label Jun 28, 2021
@igorskyflyer
Copy link
Author

Got it, I guess I'll resort to making my own UI for the folder dialog. 👍

@alexr00
Copy link
Member

alexr00 commented Jun 29, 2021

@igorskyflyer if there is something that the simple file picker is missing and that you think would have broad usefulness you can also open an issue with a feature request for us to consider.

@igorskyflyer
Copy link
Author

I've been busy with work and other projects but after a long wait, I worked really hard and managed to finish my FolderPicker npm module for Visual Studio Code that implements the aforementioned behavior and shows a custom QuickPick that allows browsing and creating folders from the Command Palette, even nested/recursive folders. The extension that implements this package is available at New Folder repo.

Not perfect (yet) but it works. 😁

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

2 participants