Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new folder in simplified file dialog #71425

Closed
roblourens opened this issue Mar 29, 2019 · 5 comments · Fixed by #152536
Closed

Create new folder in simplified file dialog #71425

roblourens opened this issue Mar 29, 2019 · 5 comments · Fixed by #152536
Assignees
@alexr00
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders simple-file-dialog Issues with simple file dialog verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2022

Comments

@roblourens
Copy link
Member

roblourens commented Mar 29, 2019 •
edited
Loading

Maybe you've already thought about this but it would be useful to be able to create a new folder in the simplified file dialog. This could be a button in the title bar or a confirmation step when a folder that doesn't exist was typed.

Creating a folder and opening it, and creating a folder and saving a file in it, are common workflows so it would be useful to be able to do those in one step.
@alexr00 alexr00 added feature-request Request for new features or functionality simple-file-dialog Issues with simple file dialog labels Mar 29, 2019
@alexr00 alexr00 added this to the On Deck milestone Mar 29, 2019
@alexr00 alexr00 mentioned this issue Jan 28, 2020
Closed
@alexr00 alexr00 mentioned this issue Feb 17, 2020
Closed
@alexr00 alexr00 mentioned this issue Apr 6, 2020
Closed
@alexr00 alexr00 mentioned this issue May 7, 2021
Closed
@mhanuszh
Copy link

For the meantime: https://marketplace.visualstudio.com/items?itemName=igordvlpr.new-folder

@igorskyflyer
Copy link

Hey @mhanuszh, thanks for the mention! 🙌

This was a feature I personally needed for quite some time - we all basically do those steps mentioned by @roblourens on a daily basis so I decided to code an extension for it. Even though the extension already works great, I am actually working on it right now and adding a new feature which will allow it to create new folders using the Simple file dialogs - regardless of user setting, see #127201.

If anyone's interested, I think I'll manage to finish it by tomorrow. 😄

@igorskyflyer
Copy link

I've been busy with work and other projects but after a long wait, I worked really hard and managed to finish my FolderPicker npm module for Visual Studio Code that implements the aforementioned behavior and shows a custom QuickPick that allows browsing and creating folders from the Command Palette, even nested/recursive folders. The extension that implements this package is available at New Folder repo.

Not perfect (yet) but it works. 😁

@alexr00 alexr00 mentioned this issue Nov 19, 2021
Closed
@gjsjohnmurray gjsjohnmurray mentioned this issue Dec 3, 2021
Closed
@xgdgsc
Copy link
Contributor

xgdgsc commented Feb 4, 2022

Also create new file in Open File dialog would be useful.

@alexr00 alexr00 mentioned this issue Jun 14, 2022
Closed
@zhuowei zhuowei mentioned this issue Jun 18, 2022
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 5, 2022
Balastrong pushed a commit to Balastrong/vscode that referenced this issue Aug 5, 2022
@zhuowei @alexr00
simpleFileDialog: ask user if we should create directory if it doesn'…
0fa4923 
…t exist when saving (microsoft#152536)

When saving a file using the SimpleFileDialog (for example, when editing a file over SSH), if the directory doesn't exist, the user currently has to cancel saving, create the directory, then try saving again.

This adds a prompt to allow the user to create any missing directories from the save dialog directly.

Tested with the TestResolver in Code - OSS.

I wasn't able to get the Remote - SSH extension working in Code - OSS, but it should work there, since FileService.writeFile calls mkdirp to create missing folders, so this should work with all remote providers.

Fixes microsoft#71425.

Co-authored-by: Alex Ross <alros@microsoft.com>
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 8, 2022
joyceerhl pushed a commit that referenced this issue Aug 10, 2022
@zhuowei @alexr00 @joyceerhl
simpleFileDialog: ask user if we should create directory if it doesn'…
6010aff 
…t exist when saving (#152536)

When saving a file using the SimpleFileDialog (for example, when editing a file over SSH), if the directory doesn't exist, the user currently has to cancel saving, create the directory, then try saving again.

This adds a prompt to allow the user to create any missing directories from the save dialog directly.

Tested with the TestResolver in Code - OSS.

I wasn't able to get the Remote - SSH extension working in Code - OSS, but it should work there, since FileService.writeFile calls mkdirp to create missing folders, so this should work with all remote providers.

Fixes #71425.

Co-authored-by: Alex Ross <alros@microsoft.com>
@rzhao271 rzhao271 modified the milestones: On Deck, August 2022 Aug 23, 2022
@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Aug 23, 2022
@rzhao271
Copy link
Contributor

Saving is good. Opening hasn't been implemented -- should there be a new issue for that?

@rzhao271 rzhao271 added the verified Verification succeeded label Aug 23, 2022
@roblourens roblourens mentioned this issue Aug 23, 2022
Open
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders simple-file-dialog Issues with simple file dialog verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2022
7 participants
@roblourens @xgdgsc @mhanuszh @rzhao271 @igorskyflyer @alexr00 @vscodenpa