Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new readonly modifier #12732

Closed
dbaeumer opened this issue Sep 27, 2016 · 7 comments
Closed

use new readonly modifier #12732

dbaeumer opened this issue Sep 27, 2016 · 7 comments
Assignees
@jrieken
Labels
api debt Code quality issues
Milestone
January 2017

Comments

@dbaeumer
Copy link
Member

  • VSCode Version: 1.6.0-Insider
  • OS Version: Windows

Added the following code to the TS extension when a diagnostic result comes back from the tsserver

        if (window.activeTextEditor) {
            window.activeTextEditor.options.lineNumbers = 'relative';
        }

Debugged it and the code gets executed but the line numbering doesn't change for the active editor.
@dbaeumer dbaeumer added bug Issue identified by VS Code Team member as probable bug editor labels Sep 27, 2016
@alexdima alexdima modified the milestones: September 2016, October 2016 Sep 27, 2016
@alexdima
Copy link
Member

@jrieken We should consider adopting readonly in vscode.d.ts. AFAIK activeTextEditor.selection.start.line has a similar issue

@jrieken jrieken self-assigned this Sep 29, 2016
@jrieken jrieken added api debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug editor labels Oct 5, 2016
@jrieken jrieken changed the title window.activeTextEditor.options.lineNumbers = 'relative' not working from extensions use new readonly modifier Oct 5, 2016
@jrieken
Copy link
Member

jrieken commented Oct 5, 2016

related to #6907

@jrieken
Copy link
Member

jrieken commented Oct 10, 2016

depends on TypeStrong/typedoc#234

Ikuyadeu added a commit to Ikuyadeu/vscode that referenced this issue Oct 17, 2016
@Ikuyadeu
use readonly microsoft#12732
8c3887c
@jrieken jrieken modified the milestones: November 2016, October 2016 Oct 21, 2016
@jrieken
Copy link
Member

jrieken commented Oct 21, 2016

Moving this out...

@kieferrm kieferrm mentioned this issue Nov 21, 2016
Closed
@jrieken jrieken modified the milestones: November 2016, January 2017 Dec 5, 2016
@alexdima
Copy link
Member

alexdima commented Dec 7, 2016

just fyi this is no longer an issue for editor.options, starting with 19291ef it is possible to use editor.options.tabSize = 3 and it'll work.

@alexdima alexdima removed their assignment Dec 7, 2016
@jrieken
Copy link
Member

jrieken commented Dec 7, 2016

ok. good to know

@egamma egamma mentioned this issue Dec 20, 2016
Closed
56 tasks
@jrieken
Copy link
Member

jrieken commented Dec 27, 2016

will happen in #13863

Ikuyadeu added a commit to Ikuyadeu/vscode that referenced this issue Jan 7, 2017
@Ikuyadeu
use readonly microsoft#12732
e5f5df7
@Ikuyadeu Ikuyadeu mentioned this issue Jan 7, 2017
Merged
jrieken added a commit that referenced this issue Jan 9, 2017
@jrieken
Merge pull request #18251 from Ikuyadeu/re_use_readonly
7c66baa 
Re use readonly #12732 #13863
jrieken added a commit that referenced this issue Jan 9, 2017
@jrieken
restore readonly-ness tests, #12732
286c74b
@jrieken jrieken closed this as completed Jan 9, 2017
jrieken added a commit that referenced this issue Jan 13, 2017
@jrieken
readonly in Uri, #12732
39c2de9
jrieken added a commit that referenced this issue Jan 13, 2017
@jrieken
readonly in Uri, #12732
d05a5d7
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api debt Code quality issues
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
3 participants
@jrieken @dbaeumer @alexdima