Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich hover focus outline shows under status bar hovers #127431

Closed
Tyriar opened this issue Jun 29, 2021 · 1 comment · Fixed by #127603
Closed

Rich hover focus outline shows under status bar hovers #127431

Tyriar opened this issue Jun 29, 2021 · 1 comment · Fixed by #127603
Assignees
@Tyriar
Labels
good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-hover Hover issues in the workbench
Milestone
June 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2021

Testing #127372

image

Caused by padding added in 96e6d1c
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities polish Cleanup and polish issue good first issue Issues identified as good for first-time contributors workbench-hover Hover issues in the workbench labels Jun 29, 2021
@Tyriar Tyriar added this to the Backlog milestone Jun 29, 2021
@Tyriar Tyriar self-assigned this Jun 29, 2021
@Tyriar Tyriar mentioned this issue Jun 29, 2021
Closed
jeanp413 added a commit to jeanp413/vscode that referenced this issue Jun 30, 2021
@jeanp413
Fixes microsoft#127431
cdd28e7
@jeanp413 jeanp413 mentioned this issue Jun 30, 2021
Merged
@jeanp413
Copy link
Contributor

Created PR #127603 fixing this

@Tyriar Tyriar modified the milestones: Backlog, June 2021 Jun 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-hover Hover issues in the workbench
Projects
None yet
Milestone
June 2021
Development

Successfully merging a pull request may close this issue.

Fixes rich hover focus outline shows under status bar hovers jeanp413/vscode
3 participants
@Tyriar @jeanp413 and others