add a 'managedByParent' property to 'DebugSessionOptions'

[weinand]

When creating child debug sessions programmatically, we need a way to let VS Code know how to manage the lifecycle of the newly created children. Today lifecycle requests (like "restart") are sent to the session itself. But there are use cases where the parent should be in control.

/**
 * Options for {@link debug.startDebugging starting a debug session}.
 */
export interface DebugSessionOptions {

    /**
     ... other options
     */

    /**
     * Controls whether lifecycle requests like 'restart' are sent to the newly created session or its parent session.
     * By default (if the property is false or missing), lifecycle requests are sent to the new session.
     * This property is ignored if the session has no parent session.
     */
    managedByParent?: boolean;
}

@connor4312 does this proposed API and the wording makes sense to you?

[connor4312]

Maybe it should be lifecycleManagedByParent?

[weinand]

I agree with @connor4312 that adding lifecycle to the proposed property makes it clearer what is being managed.

/**
 * Options for {@link debug.startDebugging starting a debug session}.
 */
export interface DebugSessionOptions {

    /**
     ... other options
     */

    /**
     * Controls whether lifecycle requests like 'restart' are sent to the newly created session or its parent session.
     * By default (if the property is false or missing), lifecycle requests are sent to the new session.
     * This property is ignored if the session has no parent session.
     */
    lifecycleManagedByParent?: boolean;
}

[weinand]

Proposal from above was discussed and approved on API call from July 13.

[weinand]

Since VS Code has not yet implemented this API, it does not make sense to verify it and add it to the release notes for the July 2021 release.
So I will move it to August 2021.

[weinand]

VS Code now supports the lifecycleManagedByParent API but testing this only makes sense with a debug adapter that creates child debug sessions.
@connor4312 I suggest that we test the lifecycleManagedByParent API with js-debug.

[connor4312]

I've adopted this in js-debug. Now that we have explicit signaling here, should we create a debt item to remove the previous lifecycle handling heuristics that we added with compact sessions and whatnot?

[weinand]

@connor4312 you are proposing to remove the "lifecycle handling heuristics code" but not "compact sessions", right?

[connor4312]

That's right

[weinand]

@connor4312 I've created debt item #131442 for this.