Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discoverability of notebook customization #128549

Closed
Tracked by #130200
miguelsolorio opened this issue Jul 13, 2021 · 3 comments
Closed
Tracked by #130200

Improve discoverability of notebook customization #128549

miguelsolorio opened this issue Jul 13, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook notebook-layout verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jul 13, 2021

Problem

We have a wide range of notebook settings that allow the users to change the layout and behavior of a notebook, but not many users know about them. This issue explores how to improve the discoverability of these settings and other notebook related items (Getting Started, etc.).

CleanShot 2021-07-13 at 09 29 50@2x

  • notebook.breadcrumbs.showCodeCells
  • notebook.cellFocusIndicator
  • notebook.cellToolbarLocation
  • notebook.cellToolbarVisibility
  • notebook.compactView
  • notebook.consolidatedOutputButton
  • notebook.consolidatedRunButton
  • notebook.diff.enablePreview
  • notebook.diff.ignoreMetadata
  • notebook.diff.ignoreOutputs
  • notebook.displayOrder
  • notebook.dragAndDropEnabled
  • notebook.editorOptionsCustomizations
  • notebook.experimental.useMarkdownRenderer
  • notebook.globalToolbar
  • notebook.insertToolbarLocation
  • notebook.lineNumbers
  • notebook.navigation.allowNavigateToSurroundingCells
  • notebook.outline.showCodeCells
  • notebook.showCellStatusBar
  • notebook.showFoldingControls
  • notebook.undoRedoPerCell

Proposals

Show a gear in the global toolbar

One option was to show a ⚙️ in the global toolbar where it would be more visible. Currently these options live in a ... in the toolbar but they're not as easily discoverable. This would help make the association clearer as we use the gear for customization in other areas (activity bar, command palette, settings, etc.)

CleanShot 2021-07-13 at 08 57 58@2x

Show a gear in the editor toolbar

Alternatively we could place the gear in the editor toolbar. This option was preferred by the team after internal discussions regarding the toolbars. The point being that the left side of the toolbar relates to notebook actions (run, clear, restart, etc.) and the right side was for kernel management.

CleanShot 2021-07-13 at 08 55 59@2x

@rebornix
Copy link
Member

Since currently we couldn't figure out the difference from the dropdown of notebook toolbar or the gear icon on the editor titlebar, I took the advice from @Tyriar: using different action ids for the actions contributed to the editor titlebar.

To test this, please check if you get different telemetry events when running Customize Notebook Layout or Toggle Breakcrumbs, etc actions from these two different places.

@roblourens
Copy link
Member

I think this is resolved?

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Aug 25, 2021
@mjbvz mjbvz added the verified Verification succeeded label Aug 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook notebook-layout verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @rebornix @mjbvz @miguelsolorio and others