Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a more explicit message about missing outputs when detected... #129632

Closed
greazer opened this issue Jul 27, 2021 · 3 comments
Closed

Consider a more explicit message about missing outputs when detected... #129632

greazer opened this issue Jul 27, 2021 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) notebook under-discussion Issue is under discussion for relevance, priority, approach

Comments

@greazer
Copy link
Member

greazer commented Jul 27, 2021

Testing #129463

  • Imagine a new user is opening a notebook with VS Code. No Python or Jupyter is installed and are perusing a set of notebooks for the first time.
  • They either:
    • Notice the notification asking whether they want to install extensions for Python and ignore or decline
    • Don't notice the notification
  • They are looking for a notebook with some set of output

As they scroll, they don't notice some of the cell outputs that indicate that a renderer can't be found. However, they may also see some cell output rendered, so they have no reason to believe anything is amiss.

They continue looking for output, but eventually discover they need to do an extra step and install the Jupyter extension at least.

Possible suggestions:

  • Add color and/or icon to the message indicating a renderer cannot be found to make it stand out.
  • Detect the situation and automatically display the "install additional renderers from the marketplace" quick pick
  • Show a modal dialog box indicating that some cell output may not be visible until additional renderers are installed.
  • Possibly other ideas... the above are just possibilities.
@roblourens roblourens added notebook under-discussion Issue is under discussion for relevance, priority, approach labels Jul 27, 2021
@rebornix rebornix added this to the August 2021 milestone Aug 2, 2021
@rebornix rebornix modified the milestones: August 2021, September 2021 Aug 22, 2021
@roblourens
Copy link
Member

@connor4312 I think you did this? Do you have an issue to dupe against?

@connor4312
Copy link
Member

Yea, there's now a button for outputs:

image

#123581

@roblourens roblourens removed this from the September 2021 milestone Sep 24, 2021
@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) notebook under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

7 participants
@roblourens @rebornix @DonJayamanne @connor4312 @greazer @joyceerhl and others