Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: ipynb file support out of the box #129463

Closed
4 tasks done
joyceerhl opened this issue Jul 26, 2021 · 0 comments
Closed
4 tasks done

Test: ipynb file support out of the box #129463

joyceerhl opened this issue Jul 26, 2021 · 0 comments

Comments

@joyceerhl
Copy link
Collaborator

joyceerhl commented Jul 26, 2021

Refs: #128495

Complexity: 3

Authors: @roblourens @joyceerhl @DonJayamanne @rebornix

Create Issue


This iteration we added out of the box support for rendering *.ipynb files, meaning that users should no longer need to install the Jupyter extension to view *.ipynb files in a notebook UI.

Tip: You can start VS Code with --extensions-dir /tmp/codeexts --user-data-dir /tmp/codedata to try the out of the box experience in a clean environment.

Test:

  • With no extensions installed, open an *.ipynb file. The native notebooks UI should be rendered
  • A notification to install recommended extensions for *.ipynb should appear (you may need the clean user-data-dir to see this)
  • Run button and "Select Kernel" should be rendered, user should be guided to install kernel extensions
  • If the notebook contains any outputs that are not rendered by default VS Code renderers, user should be guided to install renderer extensions
  • Install the Jupyter extension. Dev tools should not contain an error about duplicate serializer registrations
  • Try opening a bunch of *.ipynbs from GitHub and verify that we handle them well with and without the Jupyter extension installed
  • Test editing them, saving them, and test hot exit with autosave disabled
@joyceerhl joyceerhl added this to the July 2021 milestone Jul 26, 2021
@weinand weinand removed their assignment Jul 27, 2021
@Tyriar Tyriar removed their assignment Jul 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants