Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Interactive install flow is a little silly... #129652

Closed
TylerLeonhardt opened this issue Jul 28, 2021 · 10 comments
Closed

.NET Interactive install flow is a little silly... #129652

TylerLeonhardt opened this issue Jul 28, 2021 · 10 comments
Assignees

Comments

@TylerLeonhardt
Copy link
Member

Testing #129463

  1. Open an ipynb using .NET Interactive languages in it. There are some in https://github.com/TylerLeonhardt/JupyterNotebooks
  2. "Select kernel"
  3. Install Jupyter extension
  4. Open ipynb again
  5. Get 2 notifications:
    image
  6. Install .NET Interactive extension since this notebook is PowerShell
  7. open ipynb again
  8. Get 3 notifications:
    image

And I don't want to manually install the .NET SDK on this machine so I'm stopping here. Maybe that error is expected, but is the Python extension also needed?

cc @colombod @jonsequitur

@TylerLeonhardt TylerLeonhardt changed the title .NET Interactive flow is a little silly... .NET Interactive install flow is a little silly... Jul 28, 2021
@roblourens
Copy link
Member

I think this would be included in the getting started flow that @misolori has been looking into

@jonsequitur
Copy link

I haven't seen this type of bug in a while. @TylerLeonhardt, are you able to repro this with notebooks created more recently?

I think that part of the issue here might be that the older .ipynb files created for .NET Interactive didn't contain kernel and language metadata that could be used to select the correct kernel, so Python is assumed.

/cc @brettfo

@joyceerhl
Copy link
Collaborator

@jonsequitur FYI just in case, this is coming up because VS Code is shipping built-in support for ipynb files, i.e. the jupyter-notebook serializer for ipynb files that used to be in the Jupyter extension has moved into a builtin extension in VS Code that can be disabled but not uninstalled.

@joyceerhl
Copy link
Collaborator

@TylerLeonhardt Do you happen to have the dev log? Am specifically interested in "Failed to set document metadata for ..."

@TylerLeonhardt
Copy link
Member Author

@TylerLeonhardt Do you happen to have the dev log? Am specifically interested in "Failed to set document metadata for ..."

Unfortunately, that one doesn't show up anymore but I remember it was just complaining about "Unable to find appropriate .NET SDK." as well.

@TylerLeonhardt
Copy link
Member Author

@miguelsolorio
Copy link
Contributor

If I create a new .NET Interactive (C#) blank notebook and only having the Jupyter + .NET Interactive extensions installed, I still get prompted to install the Python extension. Is this still correct?

CleanShot 2021-07-28 at 09 56 43@2x

And then choosing ".NET Interactive" as the kernel I get the same messages:

CleanShot 2021-07-28 at 09 57 52@2x

CleanShot 2021-07-28 at 09 59 08@2x

I don't have any .NET SDKs installed

@DonJayamanne
Copy link
Contributor

get prompted to install the Python extension. Is this still correct?

That's not correct.

@miguelsolorio
Copy link
Contributor

I assessed the install flow for .NET notebooks and there certainly a lot of room for improvement that overlaps across VS Code + .NET:

  1. When opening a .NET notebook for the first time, the "Select a Kernel" only shows the Jupyter extension. We should detect to see if other languages are used in the notebook (C#, F#, etc.) and then show the applicable extensions
  2. The .NET Interactive Notebook extension should use the progress notification for installing .NET because this is happening in the background and there's now way for the user to know that unless you carefully read the text
  3. After .NET is installed, when clicking Run, I now get the correct kernel but then after selecting it the notebook does not run. This appears to be a bug.
CleanShot.2021-10-04.at.14.47.24.mp4

Not sure whether these issues should live in the Jupyter or .NET extension or in VS Code. Anyone have any thoughts?

@miguelsolorio
Copy link
Contributor

I've separated out the various issues into their respective repositories so will be closing this issue in favor of those.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants