Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace(ctrl+h) does not working in notebook #129781

Closed
ZZZZzzzzac opened this issue Jul 29, 2021 · 5 comments
Closed

Replace(ctrl+h) does not working in notebook #129781

ZZZZzzzzac opened this issue Jul 29, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone

Comments

@ZZZZzzzzac
Copy link

Environment data

VS Code version: 1.58.2 (user setup)
commit: c3f1263
date: 2021-07-14T22:10:15.214Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19042

  • Jupyter Extension version (available under the Extensions sidebar): v2021.8.1054968649
  • Python Extension version (available under the Extensions sidebar): v2021.7.1060902895
  • Python and/or Anaconda version: 3.9.5 64bit
  • Type of virtual environment used: N/A
  • Jupyter server running: Local

Expected behaviour

in jupyter notebook file, replace (ctrl+h) should work properly

Actual behaviour

using replace (from ctrl+h or from menu bar) to open replace window, cannot find or replace code.
replace

find (ctrl+f) works fine, and click the down arrow to expand menu, it can replace code properly
find

Steps to reproduce:

as above

@vscodebot
Copy link

vscodebot bot commented Jul 29, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Jul 29, 2021
@rebornix rebornix added feature-request Request for new features or functionality notebook labels Jul 29, 2021
@ZZZZzzzzac
Copy link
Author

and I find that find (ctrl+f) is also bugged, shown below
find_cache_wrong

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Aug 9, 2021
rebornix added a commit that referenced this issue Aug 9, 2021
@rebornix
Copy link
Member

rebornix commented Aug 9, 2021

Both two cases should be fixed now.

@rebornix rebornix closed this as completed Aug 9, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @DonJayamanne @rzhao271 @ZZZZzzzzac and others