Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quick pick items to always be visible and sticky #131128

Open
miguelsolorio opened this issue Aug 18, 2021 · 6 comments · Fixed by #158037
Open

Allow quick pick items to always be visible and sticky #131128

miguelsolorio opened this issue Aug 18, 2021 · 6 comments · Fixed by #158037
Assignees
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Aug 18, 2021

Based on internal discussions, would like to have an option in the Quick Pick item API to allow certain items to be grouped together and separated by a border. Additionally, when there are long entries in the list, it would be great to have this group always visible like below (see items at the bottom of the quick pick):

CleanShot 2021-08-18 at 13 53 40@2x

And when filtering the list, it would filter as it normally does:

CleanShot 2021-08-18 at 13 56 13@2x

CleanShot 2021-08-18 at 13 56 20@2x

cc @luabud

@miguelsolorio miguelsolorio added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Aug 18, 2021
@TylerLeonhardt
Copy link
Member

And when filtering the list, it would filter as it normally does:

It's interesting, I expected the opposite from the sticky items. There would only be one or two of them so they really are just "extra actions I always want to see" while the non-sticky bit is the "true list I'm filtering through"

@TylerLeonhardt TylerLeonhardt added the under-discussion Issue is under discussion for relevance, priority, approach label Aug 18, 2021
@miguelsolorio
Copy link
Contributor Author

I can see that. How would you navigate to those actions via keyboard though if the list is long? You'd have to go through each item in the list or go through the tab stops, which feels like a bit of a hack for something the quick pick already supports. I just imagined it would be faster to type a few characters + enter.

@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Aug 19, 2021
@TylerLeonhardt
Copy link
Member

Yeah I think that makes sense. Right now we have a concept of separators in Core... I think supporting separators in the API is a prereq of this work because ideally we can use separators to determine where the sticky starts (aka the last separator would denote stickiness).

@miguelsolorio
Copy link
Contributor Author

This might be solved via #149057 with having section headers and actions

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 18, 2022
@karrtikr
Copy link
Contributor

I can help test this, is there an option that we can specify within the QuickPickItem object?

@TylerLeonhardt
Copy link
Member

This was closed on accident

@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Aug 19, 2022
@meganrogge meganrogge removed their assignment Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants