Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pinning of commands in Run recent command quickpick #154388

Closed
meganrogge opened this issue Jul 7, 2022 · 8 comments · Fixed by #158037
Closed

Allow pinning of commands in Run recent command quickpick #154388

meganrogge opened this issue Jul 7, 2022 · 8 comments · Fixed by #158037
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan tasks Task system issues terminal General terminal issues that don't fall under another label
Milestone

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Jul 7, 2022

During the release party, someone requested being able to pin commands that you might run frequently to the top of the Terminal: run recent command quick-pick.

Another person suggested it would be helpful if doing so stored that command in user/workspace configuration for reuse.

Combining these ideas, we are thinking that pinning would create a user task, move the entry to the top in a new category favorite commands, and a gear button would appear next to the entry in the quick-pick allowing it to be configured or removed.

@Tyriar have discussed it and think this feature would help people to discover and configure tasks more easily, something I have cited is a problem even for me #152657

We would likely introduce a new task type such as savedCommand that would align in most ways with how type:shell is currently handled, but with a smaller set of supported properties initially.

@meganrogge meganrogge added feature-request Request for new features or functionality tasks Task system issues terminal General terminal issues that don't fall under another label labels Jul 7, 2022
@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2022

Another idea: "type": "shellCommand"?

@meganrogge
Copy link
Contributor Author

@misolori It might be helpful to see a mockup of this

@meganrogge
Copy link
Contributor Author

Kai suggested we first add a section to the Run task quickpick that is something like Recently run commands similar to how the npm tasks work for example.
Screen Shot 2022-07-07 at 5 41 32 PM
Screen Shot 2022-07-07 at 5 41 22 PM

@Tyriar Tyriar modified the milestones: Backlog, August 2022 Jul 8, 2022
@miguelsolorio
Copy link
Contributor

I can see having a "pin" icon on hover for each item that then adds it to its own category:

CleanShot 2022-07-11 at 15 04 34@2x

CleanShot 2022-07-11 at 15 05 25@2x

@Tyriar
Copy link
Member

Tyriar commented Jul 11, 2022

@misolori that's basically what I was envisioning. The most interesting part about this idea is how it could be an entry point into tasks. I haven't fully thought through the consequences of that though; should these instead just be their own thing, how are they persisted if so, what are we missing out on if they are not part of the tasks system.

@miguelsolorio
Copy link
Contributor

I also wonder whether this should be a quick pick option that can be used in other places? Not sure how much of a use case it would be but worth testing out

@oaahmad
Copy link

oaahmad commented Aug 5, 2022

I also wonder whether this should be a quick pick option that can be used in other places? Not sure how much of a use case it would be but worth testing out

Someone once opened an issue to pin commands (in the command palette). It was automatically closed because it did not get enough upvotes at the time, but I thought it was a good idea. So there is at least one use case to make pinning in quick inputs a generic thing that can be enabled as needed. Here is the issue I am referring to: #81584. Just something to consider.

@Tyriar
Copy link
Member

Tyriar commented Aug 10, 2022

Related: #131128

@Tyriar Tyriar removed their assignment Aug 12, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 18, 2022
Tyriar added a commit that referenced this issue Aug 18, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan tasks Task system issues terminal General terminal issues that don't fall under another label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants