Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White flash when opening a new window maximized or fullscreen #132339

Closed
RobbyCBennett opened this issue Sep 4, 2021 · 20 comments
Closed

White flash when opening a new window maximized or fullscreen #132339

RobbyCBennett opened this issue Sep 4, 2021 · 20 comments
Assignees
Labels
electron Issues and items related to Electron *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues workbench-os-integration Native OS integration issues

Comments

@RobbyCBennett
Copy link
Contributor

RobbyCBennett commented Sep 4, 2021

Does this issue occur when all extensions are disabled?: Yes

Version: 1.60.0 (user setup)
Commit: e7d7e9a
Date: 2021-09-01T10:41:52.311Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

Steps to Reproduce:

  1. Set "Window: New Window Dimensions" to "maximized" or "fullscreen"
  2. From an existing instance of vscode, open a new instance

The issue was reported here and closed because Electron 8 apparently fixed the issue. However, I'm still having this issue with Electron 13 on Windows. The issue is not present on Manjaro.

@deepak1556
Copy link
Collaborator

/gifPlease

@deepak1556 deepak1556 added the windows VS Code on Windows issues label Sep 8, 2021
@RobbyCBennett
Copy link
Contributor Author

78008708-56a84600-7383-11ea-8c60-90d608a89e56

@deepak1556
Copy link
Collaborator

Are you running via WSL ? Does the issue repro if you launch with code --disable-gpu ?

@RobbyCBennett
Copy link
Contributor Author

RobbyCBennett commented Sep 9, 2021

I don't normally use WSL to launch. That is just a gif I found on a previous issue that was similar, but that issue had a different cause and fix. The white flash looks the exact same to me. It occurs when I launch from the Windows GUI, from CMD, or from WSL.

I only have a dedicated graphics card and no integrated graphics on my Ryzen CPU, so I wouldn't expect anything different to happen. I have tried code --disable-gpu in CMD and WSL and I still have the white flash.

@deepak1556
Copy link
Collaborator

Can you provide a screen capture from your device showing the exact steps of launch ? Also attach the output of code --verbose

@RobbyCBennett
Copy link
Contributor Author

RobbyCBennett commented Sep 9, 2021

Like I said, it happens when launching from the terminal or from the GUI. It looks exactly like the GIF, and the flash of white is the exact same. I could record 7 different gifs, one from the launching in taskbar, one from the start menu, one from a desktop icon, a new window from VSCode, from CMD, Powershell, and WSL. It all results in the same thing.

The important step is that it first opens maximized or fullscreen on the Windows operating system.

[main 2021-09-09T03:32:20.601Z] Sending some foreground love to the running instance: 3180
[main 2021-09-09T03:32:20.606Z] Sending env to running instance...
[main 2021-09-09T03:32:20.728Z] Sent env to running instance. Terminating...
[main 2021-09-09T03:32:20.728Z] Lifecycle#kill()

@deepak1556
Copy link
Collaborator

I could record 7 different gifs, one from the launching in taskbar, one from the start menu, one from a desktop icon, a new window from VSCode, from CMD, Powershell, and WSL.

Yes it is fine, please attach a recording of what you are observing.

As for the code --verbose output, looks like you are already having a running instance. Please close all running instances and run that command.

@RobbyCBennett
Copy link
Contributor Author

RobbyCBennett commented Sep 9, 2021

Here's the log file for opening the first instance, although it's a bit cluttered because of extensions and workspaces. I have already reproduced the error without extensions on a new install of VSCode Insiders, so extensions, themes, and workspaces are irrelevant.
output.txt

@RobbyCBennett
Copy link
Contributor Author

Were you able to reproduce the issue? I couldn't get the screencast website you shared to work. Anyway, this makes no difference.

@yume-chan
Copy link
Contributor

I can reproduce this

Version: 1.63.0-insider (user setup)
Commit: d18d093403b12a65350c58a7b0d5771cc1f42aba
Date: 2021-11-26T08:21:30.810Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

log.txt

Recording.2021-11-29.at.4.40.54.PM.mp4

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Dec 2, 2021
@deepak1556 deepak1556 added this to the December 2021 milestone Dec 2, 2021
@lllopo
Copy link

lllopo commented Feb 18, 2022

I've started getting this recently. Like 3-4 builds ago along with another more annoying issue - when VS code touches the bottom of the screen (even not maximized) it prevents the taskbar from showing up when I move the mouse to the bottom.

@rzhao271 rzhao271 added the upstream-issue-linked This is an upstream issue that has been reported upstream label Sep 13, 2022
@rzhao271
Copy link
Contributor

Upstream issue:
electron/electron#35362

Chromium gets the message handler to show a window before the content window. The window that the message handler shows has a white background.

I notice that if I edit Chromium's OnPaint handler, I can get it to paint a black background by moving a line that calls FillRect out of the if statement so that it always runs. This is more a proof of concept rather than an actual fix for the issue.

However, even with that fix, there is still a flash of white at the beginning.
That flash might be a Windows bug. Therefore, assuming I get to merge in a fix into Electron for this issue, the fix would shorten the length of the white background, rather than completely eliminate it.

@rzhao271
Copy link
Contributor

rzhao271 commented Oct 5, 2022

The bug still persists on Windows 11

@ghost
Copy link

ghost commented Oct 16, 2022

The video submitted by RobbyCBennett replicates exactly what I'm seeing on a fresh install of Ubuntu 22.04 with a clean install of code.

CPUs Intel(R) Core(TM) i5-1035G4 CPU @ 1.10GHz (8 x 1500)
GPU Status 2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: disabled_software video_encode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg) 0, 1, 1
Memory (System) 7.36GB (4.81GB free)
Process Argv --unity-launch
Screen Reader no
VM 0%

@rzhao271 rzhao271 added this to the Backlog milestone Dec 6, 2022
@rzhao271 rzhao271 added the workbench-os-integration Native OS integration issues label Dec 6, 2022
@RobbyCBennett
Copy link
Contributor Author

I have noticed that the issue is not currently present on Windows 11, but it is still present on Windows 10. I have made sure that VS Code is updated on both machines.

@lllopo
Copy link

lllopo commented Mar 1, 2023

Yes, definitely still present on Win 10 / latest insiders. Ms Edge and Chrome suffer from the same issue, btw.

@RobbyCBennett
Copy link
Contributor Author

On Windows 11, I'm seeing the issue again for the latest release.

Version: 1.77.0 (system setup)
Commit: 7f329fe
Date: 2023-03-29T10:02:16.981Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No

@simon-20
Copy link

simon-20 commented Oct 6, 2023

I also see this issue using Ubuntu 22.04.3 LTS, and VS Code 1.83.0

It happens when I run code --disable-gpu --disable-extensions

As further information, it displays this white flash whenever I switch to the desktop workspace on which VS Code is running.

Happy to provide further information, if someone tells me what is needed and how to provide it.

If anyone knows a temporary work around for this, of any sort, that would be much appreciated, because having it flash every time one switches to the window is really frustrating.

@RobbyCBennett
Copy link
Contributor Author

I've just tried this on a Windows 10 system that has an integrated GPU and a dedicated GPU and this time I noticed a difference between the two. Here are my results.

  • Dedicated GPU (code --disable-extensions): the white flash is longer.
  • Integrated GPU (code --disable-gpu --disable-extensions): the white flash is shorter. The 2nd time out of 3 times I ran this command, I didn't even notice a white flash.
2023-10-06.06-40-58.mp4

@deepak1556
Copy link
Collaborator

Based on #132339 (comment) and given we don't have a clear path to upstream the changes to chromium, closing as not actionable.

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@deepak1556 deepak1556 removed this from the Backlog milestone Dec 12, 2023
@deepak1556 deepak1556 added *out-of-scope Posted issue is not in scope of VS Code and removed bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member upstream-issue-linked This is an upstream issue that has been reported upstream labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron Issues and items related to Electron *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues workbench-os-integration Native OS integration issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants