Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension update visible but not installable due to engines #13303

Closed
SamVerschueren opened this issue Oct 6, 2016 · 3 comments
Closed

Extension update visible but not installable due to engines #13303

SamVerschueren opened this issue Oct 6, 2016 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions

Comments

@SamVerschueren
Copy link
Contributor

  • VSCode Version: 1.5.3
  • OS Version: macOS sierra

Steps to Reproduce:

  1. Install the final-newline extension in VS Code 1.5.3 (this is important!)
  2. It will install final-newline@0.2.0 because that one was target to 0.10.x
  3. Enable the extension and search again for the final-newline extension in the extension list. It will show that their is an update available, namely 0.3.0, but that version is targetted to ^1.6.x
  4. You can try to install the plugin, which looks like it succeeds, but when restarting VS Code, it will again show up as update.

Extension list should show 0.2.0 as 0.3.0 is not supported by VS Code 1.5.3

screen shot 2016-10-06 at 19 29 29

After installing the extension and enabling it, this is what shows up in the extension list

screen shot 2016-10-06 at 19 30 26

So it succesfully installs the correct version, only the notification shouldn't be showing.

FYI @joaomoreno

@SamVerschueren
Copy link
Contributor Author

That also makes me wonder, is engines fully semver compatible? Because I used ^1.6.x which means that it won't work on 2.0.0 if it ever comes out. So I might be better using >=1.6 instead?

@Tyriar Tyriar added the extensions Issues concerning extensions label Oct 6, 2016
@joaomoreno
Copy link
Member

#11573

Yes, it's the semver format.

@joaomoreno joaomoreno added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 7, 2016
@SamVerschueren
Copy link
Contributor Author

Thanks @joaomoreno !

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

3 participants