-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve extension engine compatibility #11573
Comments
@rebornix just hit the bug that this will fix: an extension which has a new version published, which isn't compatible with the user's version of Code, always appears out of date in the product. |
Probably not, since this is about update notifications. |
Not sure. My issue is that code is not able to connect some of my installed extensions to to the ones in the marketplace any longer. I don't get update notifications for them, but not sure if those mechanisms are linked in anyway. Also, I'm pretty sure this issue was introduced a while ago, but it's not an easy one to catch. |
Outdated check for an extension is done as follows: If the extension has defined engine property in the VSIX manifest, it is used to check its compatibility. Otherwise falls back to old way. |
Currently, an extension is deemed outdated when there's a newer version published in the Marketplace. Installing an extension requires
O(published_versions)
request roundtrips: starting from the latest version, the engine field is checked for compatibility with the current Code, and it goes on backwards from there.We should:
VSIX manifest format:
Response:
The text was updated successfully, but these errors were encountered: