Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Stop Execution" button and notebookInterruptibleKernel key don't work #133776

Closed
roblourens opened this issue Sep 24, 2021 · 3 comments
Closed

"Stop Execution" button and notebookInterruptibleKernel key don't work #133776

roblourens opened this issue Sep 24, 2021 · 3 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2022

Comments

@roblourens
Copy link
Member

We have a button in core which is essentially the same as the Interrupt button, but it never appears because a context key is not updated for kernels that implement interrupt. Not sure what the history is here.
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Sep 24, 2021
@roblourens roblourens added this to the October 2021 milestone Sep 24, 2021
@roblourens roblourens mentioned this issue Sep 24, 2021
Closed
@greazer
Copy link
Member

greazer commented Oct 8, 2021

Be sure to fix microsoft/vscode-jupyter#7661 at the same time.

@rebornix rebornix removed their assignment Oct 11, 2021
@rebornix rebornix removed the notebook label Oct 21, 2021
@roblourens roblourens modified the milestones: February 2022, March 2022 Feb 24, 2022
@roblourens roblourens modified the milestones: March 2022, April 2022 Mar 23, 2022
@TylerLeonhardt TylerLeonhardt modified the milestones: April 2022, May 2022 Apr 29, 2022
@roblourens roblourens modified the milestones: May 2022, June 2022 Jun 1, 2022
@roblourens roblourens modified the milestones: June 2022, July 2022 Jun 29, 2022
@roblourens roblourens modified the milestones: July 2022, August 2022 Jul 20, 2022
@roblourens
Copy link
Member Author

You did this right @rebornix? #128245

@roblourens roblourens assigned rebornix and unassigned roblourens Sep 28, 2022
@roblourens roblourens added the verified Verification succeeded label Sep 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

No branches or pull requests
6 participants
@roblourens @rebornix @TylerLeonhardt @greazer @tanhakabir and others