Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-menu bar shortcuts are mapped incorrectly on Dvorak #13417

Closed
chendo opened this issue Oct 10, 2016 · 2 comments
Closed

Non-menu bar shortcuts are mapped incorrectly on Dvorak #13417

chendo opened this issue Oct 10, 2016 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
March 2017

Comments

@chendo
Copy link

chendo commented Oct 10, 2016

  • VSCode Version: 1.5.3
  • OS Version: 10.12.0

Steps to Reproduce:

  1. Set keyboard layout to Dvorak
  2. Use a keyboard shortcut that isn't in the system menu bar. For example, Cmd+Shift+] for indent.
  3. Code zooms the interface, as the physical key for ] in Dvorak is =.

Shortcuts that are defined in the menu bar work correctly as they are handled by the system.

Other keyboard layouts where symbol keys are remapped may exhibit the same problem.
@alexdima alexdima added macos Issues with VS Code on MAC/OS X keybindings VS Code keybinding issues bug Issue identified by VS Code Team member as probable bug labels Oct 27, 2016
@alexdima alexdima added this to the Backlog milestone Oct 27, 2016
@HookyQR
Copy link
Contributor

HookyQR commented Nov 18, 2016

See #15624 (comment) and PR #15687

@HookyQR HookyQR mentioned this issue Dec 17, 2016
Closed
@alexdima alexdima mentioned this issue Dec 19, 2016
Closed
@alexdima alexdima added the keyboard-layout Keyboard layout issues label Mar 1, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in today's upcoming Insiders build) appear to behave correctly for this keyboard layout

image

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 24, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
4 participants
@chendo @roblourens @alexdima @HookyQR