Remove Mac specific keybindings that don't work

[HookyQR]

The thing that this attempted to provide has never worked. Removing it allows Dvorak keybindings to work correctly. Previously it caused keybindings to use the QWERTY POSITION of the key rather than the actual key.

eg. On Dvorak, the default for insert comments is "Cmd+z" which would then conflict with the undo shortcut.

The current 'fix' does nothing for 'english' based keyboards such as Dvorak, it in fact makes real weird stuff happen because of the 'reverse' mapping it tries to do.

This change will cause some keybindings to be unreachable on some keyboard layouts, but it is my view that it is better to map to the character than the key, and then allow the user (of those keyboard) to map to the key they want to use. (Ie, the problem with the '/' key on the swiss-german keyboard)

[mention-bot]

@HookyQR, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @jrieken to be potential reviewers.

[msftclas]

Hi @HookyQR, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[msftclas]

@HookyQR, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

[fakewaffle]

What's the status of this PR? I'm unable to use VSCode with a Dvorak layout.

[openam]

I'm having issues while using the Dvorak layout as well. I'd love it if this would fix those issues.

[HookyQR]

Seems the Microsoft team is uninterested. You can follow the steps at #15624 (comment) to fix it yourself. You'll have to do that for each release until they get interested in supporting us outliers. Interestingly, the problem is caused because they wanted to support a different minority group. 🙄

Cos they're so nice about it, the file that needs to be changed has moved. Have updated the referenced comment to reflect.

[HookyQR]

This will close #1492, #4712, #4619, #15624, #13417 and #6020. It will also likely close #17106, #17023, #16157, #15887 and #15711. Add a keymap extension for the keyboards you're trying to fix with the hacky code this removes and everyone will be happy. For those following 'mentioned' links from those issues. See #15624 (comment) for a resolution to your problems while this PR is ignored.

[alexdima]

I am interested in fixing this and I've already started working on it, but breaking other keyboard layouts is not an option. i.e. the proposed changes in this PR would cause other breakages.

Work has already started in https://github.com/Microsoft/node-native-keymap

I plan to investigate using e.code instead of e.keyCode since we now consume a version of Chromium that has implemented it.

[fakewaffle]

Atom doesn't seem to have this problem.

…

On Sat, Dec 17, 2016 at 12:48 AM Alexandru Dima ***@***.***> wrote: I am interested in fixing this and I've already started working on it, but breaking other keyboard layouts is not an option. Work has already started in https://github.com/Microsoft/node-native-keymap I plan to investigate using e.code instead of e.keyCode since we now consume a version of Chromium that has implemented it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#15687 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZjdiqzXjaavB57mm3Lz8DuXYr-Q3yAks5rI5PdgaJpZM4K2DDf> .

[alexdima]

Turns out things are more complicated. I have documented my findings in #17521 and that issue will track the work going forward.

[alexdima]

I am happy to say #17521 is now closed. I will validate tomorrow on a Mac the Dvorak issues to double check that they are indeed resolved.