Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⌘-key combos no longer work with alternate keyboard layout (eg Dvorak) #4619

Closed
alexeagle opened this issue Mar 23, 2016 · 2 comments
Closed

⌘-key combos no longer work with alternate keyboard layout (eg Dvorak) #4619

alexeagle opened this issue Mar 23, 2016 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
March 2017

Comments

@alexeagle
Copy link

  • VSCode Version: 0.10.11 (f291f4a)
  • OS Version: OSX 10.11.3

Steps to Reproduce:

  1. In System Preferences -> Keyboard, switch to something other than US english
  2. Try to change zoom level with ⌘-+ or open settings file with ⌘-,

In earlier release of VSCode, this worked. Did you switch from reading OS-mapped keypress to raw scancodes for input? Maybe a Chromium or Electron bug?
@jonathanloske jonathanloske mentioned this issue Apr 11, 2016
Closed
@mathiasvr
Copy link
Contributor

Probably duplicate of #1492.

@HookyQR HookyQR mentioned this issue Dec 17, 2016
Closed
@alexdima alexdima mentioned this issue Dec 19, 2016
Closed
@alexdima alexdima added keybindings VS Code keybinding issues bug Issue identified by VS Code Team member as probable bug labels Mar 1, 2017
@alexdima alexdima added this to the Backlog milestone Mar 1, 2017
@alexdima alexdima added the keyboard-layout Keyboard layout issues label Mar 1, 2017
@alexdima alexdima added the macos Issues with VS Code on MAC/OS X label Mar 13, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in today's upcoming Insiders build) appear to behave correctly for this keyboard layout

image

screen shot 2017-03-24 at 11 02 42
screen shot 2017-03-24 at 11 04 27

I have validated that the shortcuts for zooming and opening user settings work as advertised (using the OSX Keyboard Viewer)

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 24, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
4 participants
@alexeagle @roblourens @alexdima @mathiasvr