Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcut in DVORAK Keyboard #6020

Closed
sofianhw opened this issue Apr 30, 2016 · 5 comments
Closed

shortcut in DVORAK Keyboard #6020

sofianhw opened this issue Apr 30, 2016 · 5 comments
Assignees
Labels
keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X
Milestone

Comments

@sofianhw
Copy link

  • VSCode Version: 1.0.0
  • OS Version: OSX 10.11.4 (15E65)

Steps to Reproduce:

When I press "CMD"+"/" the result is "CMD"+"["
and others
Should I re-binding the shortcut

Thanks

@bpasero bpasero added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label May 2, 2016
@spywhere
Copy link
Contributor

spywhere commented May 4, 2016

Could you try it on different editor? Key mappings are different from each other. DVORAK, for example, has many varieties including DVORAK (command QWERTY) which I think is what you need.

If you want an alternative key mapping (not try to advertise though), I would suggest Karabiner which also supports most varieties of DVORAK.

@mathiasvr
Copy link
Contributor

I think this is a duplicate of #1492. My current work around is the suggestion in #1492 (comment).
VSCode is still the only editor that I have experienced this issue with.

@alexdima alexdima added the keybindings VS Code keybinding issues label Aug 9, 2016
@alexdima alexdima added this to the Backlog milestone Aug 9, 2016
@agektmr
Copy link

agektmr commented Aug 27, 2016

Hi, I'm having the similar issue (merged issue #10986). As I noted there, the biggest problem is Karabiner not working on VSCode. It works without any problems on SublimeText or Atom.
Can you take a look? This is the only blocker for me to use VSCode.

@HookyQR
Copy link
Contributor

HookyQR commented Nov 18, 2016

See #15624 (comment) and PR #15687

@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in today's upcoming Insiders build) appear to behave correctly for this keyboard layout

image


Analysis of default keybinding for editor.action.commentLine

  • editor.action.commentLine is bound by default to the key code binding cmd+/
  • / can be produced through one scan code: [BracketLeft] . i.e.
    image
  • therefore, the action is bound by default to: Cmd+[BracketLeft] i.e.
    image

I have validated that pressing Cmd+[BracketLeft] does indeed toggle line comment.


This makes me believe the fix in PR #22894 aka #17521 resolves this issue.

@alexdima alexdima removed the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Mar 24, 2017
@alexdima alexdima modified the milestones: March 2017, Backlog Mar 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues macos Issues with VS Code on MAC/OS X
Projects
None yet
Development

No branches or pull requests

7 participants