Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wayland Electron Arguments to argv.json #134612

Closed
sclel016 opened this issue Oct 7, 2021 · 4 comments
Closed

Add Wayland Electron Arguments to argv.json #134612

sclel016 opened this issue Oct 7, 2021 · 4 comments
Assignees
@deepak1556
Labels
electron Issues and items related to Electron good first issue Issues identified as good for first-time contributors linux Issues with VS Code on Linux wayland Issue related to wayland display server

Comments

@sclel016
Copy link

sclel016 commented Oct 7, 2021

This is half feature, half bug report. In a full Wayland environment code fails to launch. That's probably expected as the packaged code install doesn't use system electron and thus ignores electron-flags.conf.

The feature request is pretty simple. Can you please parse the following extra arguments in argv.json and forward to electron?

  • --enable-features=UseOzonePlatform
  • --ozone-platform=wayland

Alternativelycode could simply parse the electron flags in $XDG_CONFIG/electron-flags.conf. Either of these options would help make code much simpler to use in a Wayland environment.
@deepak1556 deepak1556 added good first issue Issues identified as good for first-time contributors linux Issues with VS Code on Linux wayland Issue related to wayland display server labels Oct 12, 2021
@deepak1556
Copy link
Collaborator

I am good with adding support for these flags in our runtime config argv.json.

@deepak1556 deepak1556 added feature-request Request for new features or functionality electron Issues and items related to Electron and removed feature-request Request for new features or functionality labels Oct 12, 2021
zzeebbii added a commit to zzeebbii/vscode that referenced this issue Oct 15, 2021
@zzeebbii
Fixes microsoft#134612: Added electron flags for wayland
af7e4d9 
enable-features and ozone-platform flag will be parsed from runtime
argv.json file.
@zzeebbii zzeebbii mentioned this issue Oct 15, 2021
Closed
zzeebbii added a commit to zzeebbii/vscode that referenced this issue Nov 9, 2021
@zzeebbii
Fixes microsoft#134612: Added electron flags for wayland
e67c2e8 
ozone-platform flag will be parsed from runtime argv.json file.
zzeebbii added a commit to zzeebbii/vscode that referenced this issue Nov 9, 2021
@zzeebbii
Fixes microsoft#134612: Added electron flags for wayland
2cc4453 
ozone-platform flag will be parsed from runtime argv.json file.
zzeebbii added a commit to zzeebbii/vscode that referenced this issue Nov 15, 2021
@zzeebbii
Fixes microsoft#134612: Added electron flags for wayland
4116982 
ozone-platform flag will be parsed from runtime argv.json file.
@Yash621
Copy link
Contributor

Yash621 commented Dec 28, 2021

@sclel016 can I work on this ?

@sclel016
Copy link
Author

By all means, that would be great!

@deepak1556 deepak1556 mentioned this issue May 10, 2022
Closed
@noahtallen noahtallen mentioned this issue May 13, 2022
Closed
@deepak1556
Copy link
Collaborator

Refs #135191 (comment)

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
@deepak1556 deepak1556 mentioned this issue Sep 8, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
electron Issues and items related to Electron good first issue Issues identified as good for first-time contributors linux Issues with VS Code on Linux wayland Issue related to wayland display server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #134612: Added electron flags for wayland zzeebbii/vscode
3 participants
@deepak1556 @sclel016 @Yash621