Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection #134790

Closed
Tyriar opened this issue Oct 11, 2021 · 2 comments · Fixed by #145628
Closed

Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection #134790

Tyriar opened this issue Oct 11, 2021 · 2 comments · Fixed by #145628
Assignees
@meganrogge
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
March 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 11, 2021

Forked off from #28768

Upstream issue: xtermjs/xterm.js#1653

We want find to highlight all matches in the viewport using a different highlight to regular selection, just like in the editor:

image
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal Integrated terminal issues upstream-issue-linked This is an upstream issue that has been reported upstream labels Oct 11, 2021
@Tyriar Tyriar added this to the Backlog milestone Oct 11, 2021
@Tyriar Tyriar changed the title Terminal Find: Highlight all instances of term in current viewport Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection Oct 11, 2021
@Tyriar Tyriar mentioned this issue Oct 11, 2021
Closed
7 tasks
@ican2056
Copy link

Why not open the search function of Chrome. Just do not disable the shortcut keys.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 4, 2022

@ican2056 the terminal is normally displayed on a canvas, the browser's find has no access to that. Plus even when it is rendered in the DOM, only the viewport is, not the entire buffer.

@Tyriar Tyriar modified the milestones: Backlog, February 2022 Feb 1, 2022
@Tyriar Tyriar removed their assignment Feb 2, 2022
@kieferrm kieferrm mentioned this issue Feb 7, 2022
Closed
81 tasks
@Tyriar Tyriar modified the milestones: February 2022, March 2022 Feb 25, 2022
@yume-chan yume-chan mentioned this issue Mar 4, 2022
Closed
@kieferrm kieferrm mentioned this issue Mar 6, 2022
Closed
87 tasks
@Tyriar Tyriar mentioned this issue Mar 7, 2022
Closed
@Tyriar Tyriar mentioned this issue Mar 18, 2022
Merged
This was referenced Mar 21, 2022
Merged
Closed
@Tyriar Tyriar mentioned this issue Mar 22, 2022
Closed
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
March 2022
Development

Successfully merging a pull request may close this issue.

use decorations for terminal find microsoft/vscode
4 participants
@Tyriar @ican2056 @meganrogge and others