Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: terminal find / display all matches #145629

Closed
3 tasks done
meganrogge opened this issue Mar 21, 2022 · 1 comment
Closed
3 tasks done

Test: terminal find / display all matches #145629

meganrogge opened this issue Mar 21, 2022 · 1 comment

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Mar 21, 2022

Refs: #134790

Complexity: 3

Authors: @meganrogge

Create Issue


We want to align the terminal find experience with that of the editor, so this iteration, made use of the new Xterm registerDecoration API to do so.

Verify that the find experience in the terminal:

  • feels nice
  • looks good
  • behaves similarly to the editor
  • shows scrollbar annotations in the right places and an indicator for the currently selected term that updates with findNext and findPrevious
  • try setting workbench.colorCustomizations.editor.findMatchBackground and workbench.colorCustomizations.editor.findMatchHighlightBackground to custom colors. These should work on the next search
  • try searching for something then adding lines to the buffer - the search results should be updated
  • scrolling shouldn't impact anything
  • closing the find widget (that still has input) should remove the decorations
  • clearing the find widget should delete the decorations

Known issues:

@meganrogge meganrogge self-assigned this Mar 21, 2022
@meganrogge meganrogge added this to the March 2022 milestone Mar 21, 2022
@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2022

Added myself as a tester despite doing a bit of the end work on it as I want to test it thoroughly anyway.

@ghost ghost assigned sandy081, Tyriar and gregvanl Mar 22, 2022
@gregvanl gregvanl removed their assignment Mar 23, 2022
@sandy081 sandy081 removed their assignment Mar 23, 2022
@Tyriar Tyriar removed their assignment Mar 23, 2022
@Tyriar Tyriar closed this as completed Mar 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants