Terminal find match in overview ruler doesn't update immediately when changing theme

[gregvanl]

Testing #145629

On Windows 11 and Linux

Changed editor.findMatchBackground and editor.findMatchHighlightBackground:

    "workbench.colorCustomizations": {
        "editor.findMatchBackground": "#ff0000",
        "editor.findMatchHighlightBackground": "#00ff00"
    }

The color customizations worked in the regular editor but don't appear to work in the terminal find results

[meganrogge]

They'll work on the next search - not for existing decorations

[gregvanl]

I've never seen the colors applied. I've tried:
start a new search
close and reopen the Find widget
delete all terminals and create a new
reload the window

[meganrogge]

This is working for me in insider's. @gregvanl pls reopen if you can repro a case where that doesn't happen

[Tyriar]

We want to figure out how to redraw the canvas immediately when changing the theme when there are find results. The red bar is find results and should be green here:

[meganrogge]

xtermjs/xterm.js#3729

[meganrogge]

fixed with #147116

[rzhao271]

I tried using Greg's colours and it seems the red got applied, but not the lime:

I'm using the Night Owl Light theme.

[rzhao271]

The other match results also don't seem to have any highlighting applied.

[meganrogge]

@rzhao271 the setting name has changed. could you pls provide a gif?

theme.mov