Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find result decorations jump on scroll #145789

Closed
meganrogge opened this issue Mar 22, 2022 · 3 comments
Closed

find result decorations jump on scroll #145789

meganrogge opened this issue Mar 22, 2022 · 3 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
April 2022

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Mar 22, 2022 •
edited
Loading

Testing #145629

scroll-bounce.mov
@meganrogge meganrogge added terminal-find Relating the terminal's find widget bug Issue identified by VS Code Team member as probable bug labels Mar 22, 2022
@meganrogge meganrogge added this to the March 2022 milestone Mar 22, 2022
@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2022

I can't reproduce for here, you might be seeing skipped frames because it's taking too long to update in which case this would be as expected unless we can speed it up?

@meganrogge meganrogge added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 23, 2022
@meganrogge meganrogge modified the milestones: March 2022, April 2022 Mar 23, 2022
@meganrogge
Copy link
Contributor Author

meganrogge commented Mar 23, 2022 •
edited
Loading

We will want to try to use the renderer's animation frame if it's available, using our separate one only if the renderService is not rendering

@meganrogge
Copy link
Contributor Author

/duplicate

@meganrogge meganrogge added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal-find Relating the terminal's find widget upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge