Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal high contrast focus border is hidden under the canvas #145748

Closed
Tyriar opened this issue Mar 22, 2022 · 1 comment
Closed

Terminal high contrast focus border is hidden under the canvas #145748

Tyriar opened this issue Mar 22, 2022 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc. verified Verification succeeded
Milestone
March 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2022

Testing #145629

image

Related: #145725
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc. labels Mar 22, 2022
@Tyriar Tyriar added this to the March 2022 milestone Mar 22, 2022
@meganrogge
Copy link
Contributor

probably because of the high z-index we had to use

@Tyriar Tyriar closed this as completed in 6df0027 Mar 24, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 24, 2022
gabritto pushed a commit to gabritto/vscode that referenced this issue Mar 25, 2022
@Tyriar @gabritto
Fix hc focus outline in terminal
df9855b 
Fixes microsoft#145748
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc. verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
4 participants
@Tyriar @rzhao271 @meganrogge and others