Contrast isn't great in find results

[Tyriar]

Testing #145629

We draw the find match selection on top of the text which reduces contrast pretty badly

Terminal:

Editor:

Should we use a border instead of a solid rectangle to workaround this? It would look different from the editor but at least it wouldn't introduce contrast problems

This is what it looks like with these style overrides:

.xterm-decoration.xterm-find-result-decoration {
    border: 1px solid rgba(234, 92, 0, 1) !important;
    box-sizing: border-box;
    background: transparent !important;
}

The white background on selection is due to "terminal.selectionBackground": "#ffffff"

We should support border styles anyway to cover the high contrast case:

[meganrogge]

I like the idea of a border instead of a filled rectangle. It's pretty hard to see otherwise

[martin2469]

I'd like to work on this if no one else is

[Tyriar]

@martin2469 we'll be working on this in the next couple of days as it blocks the release

[rzhao271]

The border colour seems good for dark themes, but it's a bit hard to see for light ones.

[Tyriar]

We hope to move back to using background color eventually so this would get fixed then.