Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme keys for terminal find match color #145745

Closed
Tyriar opened this issue Mar 22, 2022 · 1 comment
Closed

Add theme keys for terminal find match color #145745

Tyriar opened this issue Mar 22, 2022 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget verified Verification succeeded
Milestone
March 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2022

workbench.colorCustomizations.editor.findMatchBackground and workbench.colorCustomizations.editor.findMatchHighlightBackground are used currently for the terminal find, it should have independent theme colors.

We may also need border keys: #145744
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget labels Mar 22, 2022
@Tyriar Tyriar added this to the March 2022 milestone Mar 22, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Mar 24, 2022

This was fixed in #145930

@Tyriar Tyriar closed this as completed Mar 24, 2022
@mjbvz mjbvz added the verified Verification succeeded label Mar 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
3 participants
@Tyriar @mjbvz @meganrogge